summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/content_settings_observer_browsertest.cc
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-11 00:05:16 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-11 00:05:16 +0000
commit068970d4e8a15c8915c3e3b1df16c71428a20ba5 (patch)
treecdc5e6313d188f3044a603ffc826c0b81da7e1bd /chrome/renderer/content_settings_observer_browsertest.cc
parent771c173105e8f68812fb386e278773adee6319ce (diff)
downloadchromium_src-068970d4e8a15c8915c3e3b1df16c71428a20ba5.zip
chromium_src-068970d4e8a15c8915c3e3b1df16c71428a20ba5.tar.gz
chromium_src-068970d4e8a15c8915c3e3b1df16c71428a20ba5.tar.bz2
Don't expose RenderViewImpl to tests which use RenderViewTest through its header. Instead add a few methods to RenderViewTest that Chrome tests need.
BUG=98716 Review URL: http://codereview.chromium.org/8222014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104826 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/content_settings_observer_browsertest.cc')
-rw-r--r--chrome/renderer/content_settings_observer_browsertest.cc11
1 files changed, 6 insertions, 5 deletions
diff --git a/chrome/renderer/content_settings_observer_browsertest.cc b/chrome/renderer/content_settings_observer_browsertest.cc
index 0dd54b4..206fd6f 100644
--- a/chrome/renderer/content_settings_observer_browsertest.cc
+++ b/chrome/renderer/content_settings_observer_browsertest.cc
@@ -7,6 +7,7 @@
#include "chrome/renderer/content_settings_observer.h"
#include "chrome/test/base/render_view_test.h"
#include "content/common/view_messages.h"
+#include "content/public/renderer/render_view.h"
#include "ipc/ipc_message_macros.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -79,11 +80,11 @@ TEST_F(RenderViewTest, AllowDOMStorage) {
OnAllowDOMStorage(_, _, _, _, _)).WillByDefault(DeleteArg<4>());
EXPECT_CALL(observer,
OnAllowDOMStorage(_, _, _, _, _));
- observer.AllowStorage(view_->webview()->focusedFrame(), true);
+ observer.AllowStorage(view_->GetWebView()->focusedFrame(), true);
// Accessing localStorage from the same origin again shouldn't result in a
// new IPC.
- observer.AllowStorage(view_->webview()->focusedFrame(), true);
+ observer.AllowStorage(view_->GetWebView()->focusedFrame(), true);
::testing::Mock::VerifyAndClearExpectations(&observer);
}
@@ -120,7 +121,7 @@ TEST_F(RenderViewTest, JSBlockSentAfterPageLoad) {
GURL url(url_str);
params.url = url;
params.navigation_type = ViewMsg_Navigate_Type::RELOAD;
- view_->OnNavigate(params);
+ OnNavigate(params);
ProcessPendingMessages();
// 4. Verify that the notification that javascript was blocked is sent after
@@ -155,12 +156,12 @@ TEST_F(RenderViewTest, PluginsTemporarilyAllowed) {
observer->GetContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS));
// Temporarily allow plugins.
- view_->OnMessageReceived(ChromeViewMsg_LoadBlockedPlugins(MSG_ROUTING_NONE));
+ OnMessageReceived(ChromeViewMsg_LoadBlockedPlugins(MSG_ROUTING_NONE));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
observer->GetContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS));
// Simulate a navigation within the page.
- view_->didNavigateWithinPage(GetMainFrame(), true);
+ DidNavigateWithinPage(GetMainFrame(), true);
EXPECT_EQ(CONTENT_SETTING_ALLOW,
observer->GetContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS));