summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/extensions/app_window_custom_bindings.cc
diff options
context:
space:
mode:
authorabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-27 03:31:43 +0000
committerabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-27 03:31:43 +0000
commit6be5988b8d7a1ce1749bc677cde43d31fe884d4b (patch)
tree60ea17e9e449d5954bd6b9c2c2c69685fb083dce /chrome/renderer/extensions/app_window_custom_bindings.cc
parent4e189749a72c06c4802d8c8fbe32c8f5f7fd8905 (diff)
downloadchromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.zip
chromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.tar.gz
chromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.tar.bz2
Revert 184837
Looks like it caused http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28dbg%29/builds/34570 > Set up V8 bindings for extension/app APIs when they're first used, not on > context creation. This should gives us a significant reduction in extension/app > startup time and slightly better memory usage. > > It also gives us better error messages, the chance to complete the > implementation of API features, and eventually the ability to expose select > extension APIs (e.g. extension.sendMessage) to web pages. > > BUG=163678,120070,55316,177163 > TBR=ben@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11571014 TBR=cduvall@chromium.org Review URL: https://codereview.chromium.org/12313142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions/app_window_custom_bindings.cc')
-rw-r--r--chrome/renderer/extensions/app_window_custom_bindings.cc7
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc
index 67388cf..29325d5 100644
--- a/chrome/renderer/extensions/app_window_custom_bindings.cc
+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc
@@ -49,9 +49,8 @@ class DidCreateDocumentElementObserver : public content::RenderViewObserver {
Dispatcher* dispatcher_;
};
-AppWindowCustomBindings::AppWindowCustomBindings(
- Dispatcher* dispatcher,
- v8::Handle<v8::Context> context) : ChromeV8Extension(dispatcher, context) {
+AppWindowCustomBindings::AppWindowCustomBindings(Dispatcher* dispatcher)
+ : ChromeV8Extension(dispatcher) {
RouteFunction("GetView",
base::Bind(&AppWindowCustomBindings::GetView,
base::Unretained(this)));
@@ -159,7 +158,7 @@ v8::Handle<v8::Value> AppWindowCustomBindings::GetView(
// need to make sure the security origin is set up before returning the DOM
// reference. A better way to do this would be to have the browser pass the
// opener through so opener_id is set in RenderViewImpl's constructor.
- content::RenderView* render_view = GetRenderView();
+ content::RenderView* render_view = GetCurrentRenderView();
if (!render_view)
return v8::Undefined();
WebKit::WebFrame* opener = render_view->GetWebView()->mainFrame();