diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 19:26:35 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 19:26:35 +0000 |
commit | 0f605396ab522e1f2f48824c42bb784e9784d479 (patch) | |
tree | 062f717563b296a520791bd29c25fd21038b2920 /chrome/renderer/extensions/bindings_utils.cc | |
parent | 609a1ec621cdcce03328b56e4b744ce9498b2177 (diff) | |
download | chromium_src-0f605396ab522e1f2f48824c42bb784e9784d479.zip chromium_src-0f605396ab522e1f2f48824c42bb784e9784d479.tar.gz chromium_src-0f605396ab522e1f2f48824c42bb784e9784d479.tar.bz2 |
Make the API to open a message channel symmetric, so it works the same whether opening from a tab or extension.
Also, move the callback handling back to extension_process_bindings, since I
didn't need it in event_bindings to implement this, and it didn't make sense
there anyway.
BUG=12461
TEST=no
Review URL: http://codereview.chromium.org/149237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions/bindings_utils.cc')
-rw-r--r-- | chrome/renderer/extensions/bindings_utils.cc | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/chrome/renderer/extensions/bindings_utils.cc b/chrome/renderer/extensions/bindings_utils.cc index fc9e98d..13738ca 100644 --- a/chrome/renderer/extensions/bindings_utils.cc +++ b/chrome/renderer/extensions/bindings_utils.cc @@ -44,34 +44,6 @@ v8::Handle<v8::Value> ExtensionBase::GetChromeHidden( return hidden; } -v8::Handle<v8::Value> ExtensionBase::StartRequest( - const v8::Arguments& args) { - // Get the current RenderView so that we can send a routed IPC message from - // the correct source. - RenderView* renderview = bindings_utils::GetRenderViewForCurrentContext(); - if (!renderview) - return v8::Undefined(); - - if (args.Length() != 3 || !args[0]->IsString() || !args[1]->IsInt32() || - !args[2]->IsBoolean()) - return v8::Undefined(); - - std::string name = *v8::String::AsciiValue(args.Data()); - std::string json_args = *v8::String::Utf8Value(args[0]); - int request_id = args[1]->Int32Value(); - bool has_callback = args[2]->BooleanValue(); - - v8::Persistent<v8::Context> current_context = - v8::Persistent<v8::Context>::New(v8::Context::GetCurrent()); - DCHECK(!current_context.IsEmpty()); - GetPendingRequestMap()[request_id].reset(new PendingRequest( - current_context, *v8::String::AsciiValue(args.Data()))); - - renderview->SendExtensionRequest(name, json_args, request_id, has_callback); - - return v8::Undefined(); -} - ContextList& GetContexts() { return Singleton<SingletonData>::get()->contexts; } |