diff options
author | cduvall@chromium.org <cduvall@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-09 14:26:24 +0000 |
---|---|---|
committer | cduvall@chromium.org <cduvall@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-09 14:26:24 +0000 |
commit | 4f1633f8ab00e5362a585948ff1e5231bcbca5ef (patch) | |
tree | 5f0e3e4d1d7a27970fe97074cf0aabe520a0d8ad /chrome/renderer/extensions/extension_helper.h | |
parent | 7c04e5896a71a6061ebfc13facdcf5579b7bda9d (diff) | |
download | chromium_src-4f1633f8ab00e5362a585948ff1e5231bcbca5ef.zip chromium_src-4f1633f8ab00e5362a585948ff1e5231bcbca5ef.tar.gz chromium_src-4f1633f8ab00e5362a585948ff1e5231bcbca5ef.tar.bz2 |
Set up V8 bindings for extension/app APIs when they're first used, not on
context creation. This should gives us a significant reduction in extension/app
startup time and slightly better memory usage.
It also gives us better error messages, the chance to complete the
implementation of API features, and eventually the ability to expose select
extension APIs (e.g. extension.sendMessage) to web pages.
Resubmitting: changes made to resubmit this patch reviewed in: https://codereview.chromium.org/12378077/
BUG=163678,120070,55316,177163
TBR=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186643
Review URL: https://chromiumcodereview.appspot.com/11571014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187143 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions/extension_helper.h')
-rw-r--r-- | chrome/renderer/extensions/extension_helper.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/renderer/extensions/extension_helper.h b/chrome/renderer/extensions/extension_helper.h index 9e7d21e..4a6b0b9 100644 --- a/chrome/renderer/extensions/extension_helper.h +++ b/chrome/renderer/extensions/extension_helper.h @@ -64,6 +64,10 @@ class ExtensionHelper int browser_window_id() const { return browser_window_id_; } chrome::ViewType view_type() const { return view_type_; } + // Helper to add a logging message to the root frame's console. + void AddMessageToRootConsole(content::ConsoleMessageLevel level, + const std::string& message); + private: // RenderViewObserver implementation. virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; @@ -112,7 +116,7 @@ class ExtensionHelper void DidDownloadApplicationIcon(webkit_glue::ImageResourceFetcher* fetcher, const SkBitmap& image); - // Helper to add an logging message to the root frame's console. + // Helper to add a logging message to the root frame's console. void AddMessageToRootConsole(content::ConsoleMessageLevel level, const string16& message); |