Rename ExtensionBase to ChromeV8Extension and simplify.

Remove JsOnlyV8Extensions since we can just create instances of ChromeV8Extension where necessary.

Instead of using made-up names like "chrome/extensionprocessbindings", standardize on the path to the file as the name of an extension.

Review URL: http://codereview.chromium.org/8100014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103624 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 10 deletions

diff --git a/chrome/renderer/extensions/renderer_extension_bindings.cc b/chrome/renderer/extensions/renderer_extension_bindings.cc
index 4e7811b..c52233b 100644
--- a/chrome/renderer/extensions/renderer_extension_bindings.cc
+++ b/chrome/renderer/extensions/renderer_extension_bindings.cc
@@ -12,8 +12,8 @@
 #include "chrome/common/extensions/extension_message_bundle.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/url_constants.h"
+#include "chrome/renderer/extensions/chrome_v8_extension.h"
 #include "chrome/renderer/extensions/event_bindings.h"
-#include "chrome/renderer/extensions/extension_base.h"
 #include "chrome/renderer/extensions/extension_bindings_context.h"
 #include "chrome/renderer/extensions/extension_dispatcher.h"
 #include "content/renderer/render_thread.h"
@@ -59,14 +59,15 @@ static void ClearPortData(int port_id) {
 }
 
 const char kPortClosedError[] = "Attempting to use a disconnected port object";
-const char* kExtensionDeps[] = { EventBindings::kName };
+const char* kExtensionDeps[] = { "extensions/event.js" };
 
-class ExtensionImpl : public ExtensionBase {
+class ExtensionImpl : public ChromeV8Extension {
  public:
   explicit ExtensionImpl(ExtensionDispatcher* dispatcher)
-      : ExtensionBase(RendererExtensionBindings::kName,
-                      GetStringResource(IDR_RENDERER_EXTENSION_BINDINGS_JS),
-                      arraysize(kExtensionDeps), kExtensionDeps, dispatcher) {
+      : ChromeV8Extension("extensions/renderer_extension_bindings.js",
+                          IDR_RENDERER_EXTENSION_BINDINGS_JS,
+                          arraysize(kExtensionDeps), kExtensionDeps,
+                          dispatcher) {
   }
   ~ExtensionImpl() {}
 
@@ -85,7 +86,7 @@ class ExtensionImpl : public ExtensionBase {
     } else if (name->Equals(v8::String::New("GetL10nMessage"))) {
       return v8::FunctionTemplate::New(GetL10nMessage);
     }
-    return ExtensionBase::GetNativeFunction(name);
+    return ChromeV8Extension::GetNativeFunction(name);
   }
 
   // Creates a new messaging channel to the given extension.
@@ -246,9 +247,6 @@ class ExtensionImpl : public ExtensionBase {
 
 }  // namespace
 
-const char* RendererExtensionBindings::kName =
-    "chrome/RendererExtensionBindings";
-
 v8::Extension* RendererExtensionBindings::Get(ExtensionDispatcher* dispatcher) {
   static v8::Extension* extension = new ExtensionImpl(dispatcher);
   return extension;