summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/extensions/runtime_custom_bindings.cc
diff options
context:
space:
mode:
authorabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-27 03:31:43 +0000
committerabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-27 03:31:43 +0000
commit6be5988b8d7a1ce1749bc677cde43d31fe884d4b (patch)
tree60ea17e9e449d5954bd6b9c2c2c69685fb083dce /chrome/renderer/extensions/runtime_custom_bindings.cc
parent4e189749a72c06c4802d8c8fbe32c8f5f7fd8905 (diff)
downloadchromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.zip
chromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.tar.gz
chromium_src-6be5988b8d7a1ce1749bc677cde43d31fe884d4b.tar.bz2
Revert 184837
Looks like it caused http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28dbg%29/builds/34570 > Set up V8 bindings for extension/app APIs when they're first used, not on > context creation. This should gives us a significant reduction in extension/app > startup time and slightly better memory usage. > > It also gives us better error messages, the chance to complete the > implementation of API features, and eventually the ability to expose select > extension APIs (e.g. extension.sendMessage) to web pages. > > BUG=163678,120070,55316,177163 > TBR=ben@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11571014 TBR=cduvall@chromium.org Review URL: https://codereview.chromium.org/12313142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions/runtime_custom_bindings.cc')
-rw-r--r--chrome/renderer/extensions/runtime_custom_bindings.cc12
1 files changed, 4 insertions, 8 deletions
diff --git a/chrome/renderer/extensions/runtime_custom_bindings.cc b/chrome/renderer/extensions/runtime_custom_bindings.cc
index 22af19c..211ad62 100644
--- a/chrome/renderer/extensions/runtime_custom_bindings.cc
+++ b/chrome/renderer/extensions/runtime_custom_bindings.cc
@@ -18,10 +18,8 @@ using content::V8ValueConverter;
namespace extensions {
-RuntimeCustomBindings::RuntimeCustomBindings(Dispatcher* dispatcher,
- ChromeV8Context* context)
- : ChromeV8Extension(dispatcher, context->v8_context()),
- context_(context) {
+RuntimeCustomBindings::RuntimeCustomBindings(ChromeV8Context* context)
+ : ChromeV8Extension(NULL), context_(context) {
RouteFunction("GetManifest",
base::Bind(&RuntimeCustomBindings::GetManifest, base::Unretained(this)));
RouteStaticFunction("OpenChannelToExtension", &OpenChannelToExtension);
@@ -35,8 +33,7 @@ v8::Handle<v8::Value> RuntimeCustomBindings::OpenChannelToExtension(
const v8::Arguments& args) {
// Get the current RenderView so that we can send a routed IPC message from
// the correct source.
- RuntimeCustomBindings* self = GetFromArguments<RuntimeCustomBindings>(args);
- content::RenderView* renderview = self->GetRenderView();
+ content::RenderView* renderview = GetCurrentRenderView();
if (!renderview)
return v8::Undefined();
@@ -64,8 +61,7 @@ v8::Handle<v8::Value> RuntimeCustomBindings::OpenChannelToNativeApp(
const v8::Arguments& args) {
// Get the current RenderView so that we can send a routed IPC message from
// the correct source.
- RuntimeCustomBindings* self = GetFromArguments<RuntimeCustomBindings>(args);
- content::RenderView* renderview = self->GetRenderView();
+ content::RenderView* renderview = GetCurrentRenderView();
if (!renderview)
return v8::Undefined();