diff options
author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
---|---|---|
committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
commit | 2c58efc6135102d815c34d518d14c0bfc5c27f5b (patch) | |
tree | bf47fee779ada375a0007e4cc7b527e86a0293a3 /chrome/renderer/extensions | |
parent | 48844c643cca3d7d21043e46c228585e68618e31 (diff) | |
download | chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.zip chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.gz chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.bz2 |
Revert 33255 - Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
browser: all enabled extensions
renderer: unique set of extensions from all user scripts
extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
--
There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions')
-rw-r--r-- | chrome/renderer/extensions/extension_process_bindings.cc | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/chrome/renderer/extensions/extension_process_bindings.cc b/chrome/renderer/extensions/extension_process_bindings.cc index 87efbc4..98b45f1 100644 --- a/chrome/renderer/extensions/extension_process_bindings.cc +++ b/chrome/renderer/extensions/extension_process_bindings.cc @@ -9,11 +9,8 @@ #include <string> #include <vector> -#include "base/command_line.h" #include "base/json/json_reader.h" #include "base/singleton.h" -#include "chrome/common/child_process_logging.h" -#include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_message_bundle.h" #include "chrome/common/extensions/url_pattern.h" @@ -105,19 +102,6 @@ static L10nMessagesMap* GetL10nMessagesMap(const std::string extension_id) { } } -static std::vector<std::string> GetActiveExtensionIDs() { - std::vector<std::string> extension_ids; - ExtensionPermissionsMap& permissions = - Singleton<SingletonData>()->permissions_; - - for (ExtensionPermissionsMap::iterator iter = permissions.begin(); - iter != permissions.end(); ++iter) { - extension_ids.push_back(iter->first); - } - - return extension_ids; -} - // A RenderViewVisitor class that iterates through the set of available // views, looking for a view of the given type, in the given browser window // and within the given extension. @@ -642,12 +626,6 @@ void ExtensionProcessBindings::SetAPIPermissions( permissions_map[Extension::kPermissionNames[i]] = false; for (size_t i = 0; i < permissions.size(); ++i) permissions_map[permissions[i]] = true; - - // Ugly hack. We also update our list of active extensions here. This always - // gets called, even if the extension has no api permissions. In single - // process, this has already been done in the browser code. - if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess)) - child_process_logging::SetActiveExtensions(GetActiveExtensionIDs()); } // static |