diff options
author | cira@chromium.org <cira@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-11 00:20:09 +0000 |
---|---|---|
committer | cira@chromium.org <cira@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-11 00:20:09 +0000 |
commit | 1e07f78cf624f3ab8f14a21d80c8999595da21ea (patch) | |
tree | 41002a66bbe994cf56155696d309fbbc159c2d02 /chrome/renderer/extensions | |
parent | 9393b71775c7ea64004df0461d0564361bddd553 (diff) | |
download | chromium_src-1e07f78cf624f3ab8f14a21d80c8999595da21ea.zip chromium_src-1e07f78cf624f3ab8f14a21d80c8999595da21ea.tar.gz chromium_src-1e07f78cf624f3ab8f14a21d80c8999595da21ea.tar.bz2 |
Replace __MSG_some_name__ template within extension css files with localized messages.
We avoid replacing messages within html and js extension files for security reasons. Also, developers can already localize messages in html/js using chrome.i18n.getMessage calls.
TEST=Localize extension, try body{direction: __MSG_@@bidi_reversed_dir__;} in popup.css, while using non-rtl locale. Text should be alligned to the right (as if we were using rtl locale).
BUG=26144
Review URL: http://codereview.chromium.org/570007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38717 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/extensions')
-rw-r--r-- | chrome/renderer/extensions/renderer_extension_bindings.cc | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/chrome/renderer/extensions/renderer_extension_bindings.cc b/chrome/renderer/extensions/renderer_extension_bindings.cc index 54231b6..2f50143 100644 --- a/chrome/renderer/extensions/renderer_extension_bindings.cc +++ b/chrome/renderer/extensions/renderer_extension_bindings.cc @@ -35,12 +35,6 @@ using bindings_utils::ExtensionBase; namespace { -// A map of message name to message. -typedef std::map<std::string, std::string> L10nMessagesMap; - -// A map of extension ID to l10n message map. -typedef std::map<std::string, L10nMessagesMap > ExtensionToL10nMessagesMap; - struct ExtensionData { struct PortData { int ref_count; // how many contexts have a handle to this port @@ -48,8 +42,6 @@ struct ExtensionData { PortData() : ref_count(0), disconnected(false) {} }; std::map<int, PortData> ports; // port ID -> data - // Maps extension ID to message map. - ExtensionToL10nMessagesMap extension_l10n_messages_map_; }; static bool HasPortData(int port_id) { @@ -65,21 +57,6 @@ static void ClearPortData(int port_id) { Singleton<ExtensionData>::get()->ports.erase(port_id); } -static ExtensionToL10nMessagesMap* GetExtensionToL10nMessagesMap() { - return &Singleton<ExtensionData>()->extension_l10n_messages_map_; -} - -static L10nMessagesMap* GetL10nMessagesMap(const std::string extension_id) { - ExtensionToL10nMessagesMap::iterator it = - Singleton<ExtensionData>()->extension_l10n_messages_map_.find( - extension_id); - if (it != Singleton<ExtensionData>()->extension_l10n_messages_map_.end()) { - return &(it->second); - } else { - return NULL; - } -} - const char kPortClosedError[] = "Attempting to use a disconnected port object"; const char* kExtensionDeps[] = { EventBindings::kName }; @@ -230,8 +207,6 @@ class ExtensionImpl : public ExtensionBase { l10n_messages_map[extension_id] = messages; l10n_messages = GetL10nMessagesMap(extension_id); - if (!l10n_messages) - return v8::Undefined(); } std::string message_name = *v8::String::AsciiValue(args[0]); |