summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/form_manager.h
diff options
context:
space:
mode:
authorhayato@chromium.org <hayato@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-31 09:34:50 +0000
committerhayato@chromium.org <hayato@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-31 09:34:50 +0000
commite6efd025246dc04f22ee0f62a25e1259ab95512e (patch)
treea7bee5e86797af0826bf2cbda24070526ef33b60 /chrome/renderer/form_manager.h
parent5c43b97cfe76c02c88900a4c68326adac842b7be (diff)
downloadchromium_src-e6efd025246dc04f22ee0f62a25e1259ab95512e.zip
chromium_src-e6efd025246dc04f22ee0f62a25e1259ab95512e.tar.gz
chromium_src-e6efd025246dc04f22ee0f62a25e1259ab95512e.tar.bz2
Page Cycler Intl2 perf regression.
Revert 43181 - AutoFill: Send the forms cached in the FormManager to the AutoFillManager on page load instead of duplicating this parsing in RenderView. BUG=38325 TEST=none Review URL: http://codereview.chromium.org/1530011 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/1540008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43195 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/form_manager.h')
-rw-r--r--chrome/renderer/form_manager.h24
1 files changed, 4 insertions, 20 deletions
diff --git a/chrome/renderer/form_manager.h b/chrome/renderer/form_manager.h
index cc19bd8..5445a4f 100644
--- a/chrome/renderer/form_manager.h
+++ b/chrome/renderer/form_manager.h
@@ -12,7 +12,6 @@
#include "third_party/WebKit/WebKit/chromium/public/WebFormControlElement.h"
#include "third_party/WebKit/WebKit/chromium/public/WebFormElement.h"
#include "webkit/glue/form_data.h"
-#include "webkit/glue/form_field_values.h"
namespace WebKit {
class WebFrame;
@@ -32,17 +31,12 @@ class FormManager {
virtual ~FormManager();
// Scans the DOM in |frame| extracting and storing forms.
- void ExtractForms(const WebKit::WebFrame* frame);
+ void ExtractForms(WebKit::WebFrame* frame);
// Returns a vector of forms that match |requirements|.
void GetForms(std::vector<webkit_glue::FormData>* forms,
RequirementsMask requirements);
- // Returns a vector of forms in |frame| that match |requirements|.
- void GetFormsInFrame(const WebKit::WebFrame* frame,
- RequirementsMask requirements,
- std::vector<webkit_glue::FormData>* forms);
-
// Finds the form that contains |element| and returns it in |form|. Returns
// false if the form is not found.
bool FindForm(const WebKit::WebFormControlElement& element,
@@ -58,16 +52,6 @@ class FormManager {
// Resets the stored set of forms.
void Reset();
- // TODO(jhawkins): Remove this method once AutoFillManager uses FormData.
- static void FormDataToFormFieldValues(
- const std::vector<webkit_glue::FormData>& forms,
- std::vector<webkit_glue::FormFieldValues>* form_field_values);
-
- // Creates a FormField object from a given WebFormControlElement.
- static void WebFormControlElementToFormField(
- const WebKit::WebFormControlElement& element,
- webkit_glue::FormField* field);
-
private:
// A map of WebFormControlElements keyed by each element's name.
typedef std::map<string16, WebKit::WebFormControlElement>
@@ -82,15 +66,15 @@ class FormManager {
// A map of vectors of FormElements keyed by the WebFrame containing each
// form.
- typedef std::map<const WebKit::WebFrame*, std::vector<FormElement*> >
+ typedef std::map<WebKit::WebFrame*, std::vector<FormElement*> >
WebFrameFormElementMap;
// Resets the forms for the specified |frame|.
- void ResetFrame(const WebKit::WebFrame* frame);
+ void ResetFrame(WebKit::WebFrame* frame);
// Converts a FormElement to FormData storage.
// TODO(jhawkins): Modify FormElement so we don't need |frame|.
- void FormElementToFormData(const WebKit::WebFrame* frame,
+ void FormElementToFormData(WebKit::WebFrame* frame,
const FormElement* form_element,
RequirementsMask requirements,
webkit_glue::FormData* form);