summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/ggl
diff options
context:
space:
mode:
authorapatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 18:42:43 +0000
committerapatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 18:42:43 +0000
commit8a880c328848de5dbef6e081a7f3e0c847672aed (patch)
treec522f3f70bc4fc348f920e0c1f82facec37bbf9f /chrome/renderer/ggl
parent797334f61deaa372be3259c83ca3887714ec9aca (diff)
downloadchromium_src-8a880c328848de5dbef6e081a7f3e0c847672aed.zip
chromium_src-8a880c328848de5dbef6e081a7f3e0c847672aed.tar.gz
chromium_src-8a880c328848de5dbef6e081a7f3e0c847672aed.tar.bz2
Fixed race where GPU process rendered to invalid window handle.
ggl::DestroyContext now does not return until the GPU process has stopped using the window handle so that clients can correctly coordinate the destruction of the window. TEST=try BUG=none Review URL: http://codereview.chromium.org/3152027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/ggl')
-rw-r--r--chrome/renderer/ggl/ggl.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/renderer/ggl/ggl.h b/chrome/renderer/ggl/ggl.h
index b005d56..fd1cd56 100644
--- a/chrome/renderer/ggl/ggl.h
+++ b/chrome/renderer/ggl/ggl.h
@@ -37,7 +37,10 @@ bool Initialize();
// have completed.
bool Terminate();
-// Create a GGL context that renders directly to a view.
+// Create a GGL context that renders directly to a view. The view and the
+// associated window must not be destroyed until the returned context has been
+// destroyed, otherwise the GPU process might attempt to render to an invalid
+// window handle.
//
// NOTE: on Mac OS X, this entry point is only used to set up the
// accelerated compositor's output. On this platform, we actually pass