diff options
| author | apatrick@google.com <apatrick@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 23:32:49 +0000 |
|---|---|---|
| committer | apatrick@google.com <apatrick@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 23:32:49 +0000 |
| commit | a68114f7be41610ed7fd4a85de6b76a47cfb4b1b (patch) | |
| tree | 22ffadafb2213fa7cc04884e8d99c3b4b5a36f77 /chrome/renderer/media | |
| parent | 220d58ef0334c3ed9a8dc5d44fc9c3a920dcb3a2 (diff) | |
| download | chromium_src-a68114f7be41610ed7fd4a85de6b76a47cfb4b1b.zip chromium_src-a68114f7be41610ed7fd4a85de6b76a47cfb4b1b.tar.gz chromium_src-a68114f7be41610ed7fd4a85de6b76a47cfb4b1b.tar.bz2 | |
Changed AudioRendererImplTest and DeferredResourceLoadingTest tests so they duplicate the shared memory before passing it to another object that takes ownership. Prevents same handle from being closed twice.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/449026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33372 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/media')
| -rw-r--r-- | chrome/renderer/media/audio_renderer_impl_unittest.cc | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/chrome/renderer/media/audio_renderer_impl_unittest.cc b/chrome/renderer/media/audio_renderer_impl_unittest.cc index 601fa31..1dda05d 100644 --- a/chrome/renderer/media/audio_renderer_impl_unittest.cc +++ b/chrome/renderer/media/audio_renderer_impl_unittest.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include "base/process_util.h" #include "chrome/common/render_messages.h" #include "chrome/renderer/media/audio_renderer_impl.h" #include "media/base/data_buffer.h" @@ -50,7 +51,14 @@ class AudioRendererImplTest : public ::testing::Test { // Run pending tasks and simulate responding with a created audio stream. message_loop_->RunAllPending(); - renderer_->OnCreated(shared_mem_.handle(), kSize); + + // Duplicate the shared memory handle so both the test and the callee can + // close their copy. + base::SharedMemoryHandle duplicated_handle; + EXPECT_TRUE(shared_mem_.ShareToProcess(base::GetCurrentProcessHandle(), + &duplicated_handle)); + + renderer_->OnCreated(duplicated_handle, kSize); } virtual ~AudioRendererImplTest() { |