diff options
author | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 18:21:36 +0000 |
---|---|---|
committer | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-22 18:21:36 +0000 |
commit | f1891dcc471a4df66ad639aa85b7444d657e3259 (patch) | |
tree | 5f188aee810dfbece4af2f79d62dbc2f800de6e3 /chrome/renderer/navigation_state.h | |
parent | e2af39d65c57d0aece51c06cb8761b698a8d0453 (diff) | |
download | chromium_src-f1891dcc471a4df66ad639aa85b7444d657e3259.zip chromium_src-f1891dcc471a4df66ad639aa85b7444d657e3259.tar.gz chromium_src-f1891dcc471a4df66ad639aa85b7444d657e3259.tar.bz2 |
Factor a PageLoadHistograms class out of RenderView.
No functional changes are intended.
This is in anticipation of using the new WebPerformance API:
http://trac.webkit.org/changeset/68141
My strategy is this:
1. In this patch, make the most minimal change possible to the Dump() method
necessary to factor it out to a new class.
2. Add a new, temporary histograms which log the WebPerformance metrics which
have an existing counterparts.
3. Once we understand any differences and are happy with the new metrics, rip
out the old ones. This will allow more cleanup in RenderView and
NavigationState.
4. Add new histograms for any interesting WebPerformance metrics which weren't
previously available.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63536 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/navigation_state.h')
-rw-r--r-- | chrome/renderer/navigation_state.h | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/chrome/renderer/navigation_state.h b/chrome/renderer/navigation_state.h index d9cee3e..6041389 100644 --- a/chrome/renderer/navigation_state.h +++ b/chrome/renderer/navigation_state.h @@ -152,18 +152,6 @@ class NavigationState : public WebKit::WebDataSource::ExtraData { first_paint_after_load_time_ = value; } - // Info about the URL used as the target of this navigation. - URLPattern::SchemeMasks scheme_type() const { return scheme_type_; } - void set_scheme_type(URLPattern::SchemeMasks scheme_type) { - scheme_type_ = scheme_type; - } - - // True iff the histograms for the associated frame have been dumped. - bool load_histograms_recorded() const { return load_histograms_recorded_; } - void set_load_histograms_recorded(bool value) { - load_histograms_recorded_ = value; - } - // True if we have already processed the "DidCommitLoad" event for this // request. Used by session history. bool request_committed() const { return request_committed_; } @@ -281,8 +269,6 @@ class NavigationState : public WebKit::WebDataSource::ExtraData { : transition_type_(transition_type), load_type_(UNDEFINED_LOAD), request_time_(request_time), - scheme_type_(static_cast<URLPattern::SchemeMasks>(0)), - load_histograms_recorded_(false), request_committed_(false), is_content_initiated_(is_content_initiated), pending_page_id_(pending_page_id), @@ -311,8 +297,6 @@ class NavigationState : public WebKit::WebDataSource::ExtraData { base::Time finish_load_time_; base::Time first_paint_time_; base::Time first_paint_after_load_time_; - URLPattern::SchemeMasks scheme_type_; - bool load_histograms_recorded_; bool request_committed_; bool is_content_initiated_; int32 pending_page_id_; |