diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 19:36:16 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 19:36:16 +0000 |
commit | e768baf6ebf5a49cc19d58d1761321b175c82c18 (patch) | |
tree | c29fb1ebcef46d9ad929ed1fd68f954a04f97b06 /chrome/renderer/password_autocomplete_manager.h | |
parent | a850e9592bb1a8c43275116ff565c91b4b1cb66b (diff) | |
download | chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.zip chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.tar.gz chromium_src-e768baf6ebf5a49cc19d58d1761321b175c82c18.tar.bz2 |
Separate the PasswordManagerDelegate out of PasswordManager.
Previously, anyone who included tab_contents.h would bring in a bunch of
implementation details of the password manager from webkit_glue. This breaks
the delegate interface out of the rest of password manager system and makes
FillData not an inner-class so anyone can forward declare FillData instead of
having to include the header to meet a delegate interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2877022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/password_autocomplete_manager.h')
-rw-r--r-- | chrome/renderer/password_autocomplete_manager.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/chrome/renderer/password_autocomplete_manager.h b/chrome/renderer/password_autocomplete_manager.h index a931026..5e2eee2 100644 --- a/chrome/renderer/password_autocomplete_manager.h +++ b/chrome/renderer/password_autocomplete_manager.h @@ -23,13 +23,13 @@ class WebView; class PasswordAutocompleteManager { public: explicit PasswordAutocompleteManager(RenderView* render_view); - virtual ~PasswordAutocompleteManager() {} + virtual ~PasswordAutocompleteManager(); // Invoked by the renderer when it receives the password info from the // browser. This triggers a password autocomplete (if wait_for_username is // false on |form_data|). void ReceivedPasswordFormFillData(WebKit::WebView* view, - const webkit_glue::PasswordFormDomManager::FillData& form_data); + const webkit_glue::PasswordFormFillData& form_data); // Invoked when the passed frame is closing. Gives us a chance to clear any // reference we may have to elements in that frame. @@ -46,7 +46,7 @@ class PasswordAutocompleteManager { void PerformInlineAutocomplete( const WebKit::WebInputElement& username, const WebKit::WebInputElement& password, - const webkit_glue::PasswordFormDomManager::FillData& fill_data); + const webkit_glue::PasswordFormFillData& fill_data); // WebViewClient editor related calls forwarded by the RenderView. void TextFieldDidBeginEditing(const WebKit::WebInputElement& element); @@ -58,25 +58,25 @@ class PasswordAutocompleteManager { private: struct PasswordInfo { WebKit::WebInputElement password_field; - webkit_glue::PasswordFormDomManager::FillData fill_data; + webkit_glue::PasswordFormFillData fill_data; bool backspace_pressed_last; PasswordInfo() : backspace_pressed_last(false) {} }; typedef std::map<WebKit::WebElement, PasswordInfo> LoginToPasswordInfoMap; void GetSuggestions( - const webkit_glue::PasswordFormDomManager::FillData& fill_data, + const webkit_glue::PasswordFormFillData& fill_data, const string16& input, std::vector<string16>* suggestions); bool ShowSuggestionPopup( - const webkit_glue::PasswordFormDomManager::FillData& fill_data, + const webkit_glue::PasswordFormFillData& fill_data, const WebKit::WebInputElement& user_input); bool FillUserNameAndPassword( WebKit::WebInputElement* username_element, WebKit::WebInputElement* password_element, - const webkit_glue::PasswordFormDomManager::FillData& fill_data, + const webkit_glue::PasswordFormFillData& fill_data, bool exact_username_match); // The logins we have filled so far with their associated info. |