diff options
author | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-12 18:02:02 +0000 |
---|---|---|
committer | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-12 18:02:02 +0000 |
commit | 8d83e3bb062b7848547a00170f4b26427cd0a528 (patch) | |
tree | 58abcbb349dd108830e185bc7102b2c038cac96a /chrome/renderer/pepper | |
parent | 778142fe27ea9f9df6c33b13c34a9798d448ccdc (diff) | |
download | chromium_src-8d83e3bb062b7848547a00170f4b26427cd0a528.zip chromium_src-8d83e3bb062b7848547a00170f4b26427cd0a528.tar.gz chromium_src-8d83e3bb062b7848547a00170f4b26427cd0a528.tar.bz2 |
Revert 216744 "Pepper: Move FileRef to the "new" resource proxy."
> Pepper: Move FileRef to the "new" resource proxy.
>
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
>
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
>
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
>
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
>
> Review URL: https://codereview.chromium.org/21966004
TBR=teravest@google.com
Review URL: https://codereview.chromium.org/22903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217036 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/pepper')
-rw-r--r-- | chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc | 31 | ||||
-rw-r--r-- | chrome/renderer/pepper/pepper_flash_drm_renderer_host.h | 12 |
2 files changed, 9 insertions, 34 deletions
diff --git a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc index 7f2011c..ca59c7ef 100644 --- a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc +++ b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc @@ -12,6 +12,7 @@ #include "ppapi/host/host_message_context.h" #include "ppapi/host/ppapi_host.h" #include "ppapi/proxy/ppapi_messages.h" +#include "ppapi/proxy/ppb_file_ref_proxy.h" namespace chrome { @@ -27,8 +28,7 @@ PepperFlashDRMRendererHost::PepperFlashDRMRendererHost( PP_Instance instance, PP_Resource resource) : ResourceHost(host->GetPpapiHost(), instance, resource), - renderer_ppapi_host_(host), - weak_factory_(this) { + renderer_ppapi_host_(host) { } PepperFlashDRMRendererHost::~PepperFlashDRMRendererHost() { @@ -56,26 +56,13 @@ int32_t PepperFlashDRMRendererHost::OnGetVoucherFile( base::FilePath voucher_file = plugin_dir.Append( base::FilePath(kVoucherFilename)); - renderer_ppapi_host_->CreateBrowserResourceHost( - pp_instance(), - PpapiHostMsg_FileRef_CreateExternal(voucher_file), - base::Bind(&PepperFlashDRMRendererHost::DidCreateFileRefHost, - weak_factory_.GetWeakPtr(), - context->MakeReplyMessageContext(), - voucher_file)); - return PP_OK_COMPLETIONPENDING; -} - -void PepperFlashDRMRendererHost::DidCreateFileRefHost( - const ppapi::host::ReplyMessageContext& reply_context, - const base::FilePath& external_path, - int pending_resource_id) { - ppapi::FileRefCreateInfo create_info = - ppapi::MakeExternalFileRefCreateInfo(external_path, - std::string(), - pending_resource_id); - host()->SendReply(reply_context, - PpapiPluginMsg_FlashDRM_GetVoucherFileReply(create_info)); + ppapi::PPB_FileRef_CreateInfo create_info; + ppapi::proxy::PPB_FileRef_Proxy::SerializeFileRef( + plugin_instance->CreateExternalFileReference(voucher_file), + &create_info); + context->reply_msg = + PpapiPluginMsg_FlashDRM_GetVoucherFileReply(create_info); + return PP_OK; } } // namespace chrome diff --git a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.h b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.h index a0382b6..f7247d6 100644 --- a/chrome/renderer/pepper/pepper_flash_drm_renderer_host.h +++ b/chrome/renderer/pepper/pepper_flash_drm_renderer_host.h @@ -7,13 +7,8 @@ #include "base/basictypes.h" #include "base/compiler_specific.h" -#include "base/memory/weak_ptr.h" #include "ppapi/host/resource_host.h" -namespace base { -class FilePath; -} - namespace content { class RendererPpapiHost; } @@ -36,16 +31,9 @@ class PepperFlashDRMRendererHost : public ppapi::host::ResourceHost { private: int32_t OnGetVoucherFile(ppapi::host::HostMessageContext* context); - void DidCreateFileRefHost( - const ppapi::host::ReplyMessageContext& reply_context, - const base::FilePath& external_path, - int pending_resource_id); - // Non-owning pointer. content::RendererPpapiHost* renderer_ppapi_host_; - base::WeakPtrFactory<PepperFlashDRMRendererHost> weak_factory_; - DISALLOW_COPY_AND_ASSIGN(PepperFlashDRMRendererHost); }; |