diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-20 00:22:18 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-20 00:22:18 +0000 |
| commit | 1c7dbf5de3ac41267120b1108fdaf70da61c1d50 (patch) | |
| tree | 0b47d25e5ed7dbc15d12b5ca5dbd2fb21de2135b /chrome/renderer/print_web_view_helper.h | |
| parent | ed5d53af280ce9b7a1412a38d0b2f96e8433e4d2 (diff) | |
| download | chromium_src-1c7dbf5de3ac41267120b1108fdaf70da61c1d50.zip chromium_src-1c7dbf5de3ac41267120b1108fdaf70da61c1d50.tar.gz chromium_src-1c7dbf5de3ac41267120b1108fdaf70da61c1d50.tar.bz2 | |
Printing: Remove invalid NOTREACHED for the case where user cancels printing.
BUG=none
TEST=bring up the print dialog and then cancel does not crash the renderer in debug mode.
Review URL: http://codereview.chromium.org/5231002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66853 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/print_web_view_helper.h')
| -rw-r--r-- | chrome/renderer/print_web_view_helper.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/renderer/print_web_view_helper.h b/chrome/renderer/print_web_view_helper.h index 55c006b..5fee3b9 100644 --- a/chrome/renderer/print_web_view_helper.h +++ b/chrome/renderer/print_web_view_helper.h @@ -139,12 +139,13 @@ class PrintWebViewHelper : public WebKit::WebViewClient, ViewMsg_Print_Params* params); // Get final print settings from the user. + // Return false if the user cancels or on error. bool GetPrintSettingsFromUser(WebKit::WebFrame* frame, int expected_pages_count, bool use_browser_overlays); // Render the frame for printing. - bool RenderPagesForPrint(WebKit::WebFrame* frame); + void RenderPagesForPrint(WebKit::WebFrame* frame); RenderView* render_view_; WebKit::WebView* print_web_view_; |