diff options
author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-27 21:39:15 +0000 |
---|---|---|
committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-27 21:39:15 +0000 |
commit | 18bcc3c1e8ac29683e6d09a9c2d8b3037b0fb360 (patch) | |
tree | c1941e26ff0fa733258e7c91d2f84ad436df6963 /chrome/renderer/render_thread.cc | |
parent | ab58e6cec813b33eefb397be3cebc11fcc280bdf (diff) | |
download | chromium_src-18bcc3c1e8ac29683e6d09a9c2d8b3037b0fb360.zip chromium_src-18bcc3c1e8ac29683e6d09a9c2d8b3037b0fb360.tar.gz chromium_src-18bcc3c1e8ac29683e6d09a9c2d8b3037b0fb360.tar.bz2 |
POSIX: gfx::NativeViewId and CrossProcessEvent
Create a couple new typedefs for porting work. Firstly,
gfx::NativeViewId is a handle to a platform specific widget in the
renderer process. For Windows, this is just a HWND as before. However,
in other platforms the ids used in the renderer process will be
something else.
CrossProcessEvent is the type of a HANDLE to a Windows event object
which is used across processes. Since we aren't going to support these
sorts of events on non-Windows platforms, this will have to go away at
some point. For now, however, this lets us build code without too many
ifdefs all over the place.
Review URL: http://codereview.chromium.org/18768
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8756 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_thread.cc')
-rw-r--r-- | chrome/renderer/render_thread.cc | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/chrome/renderer/render_thread.cc b/chrome/renderer/render_thread.cc index d39800f..6c45a3d 100644 --- a/chrome/renderer/render_thread.cc +++ b/chrome/renderer/render_thread.cc @@ -230,21 +230,23 @@ void RenderThread::OnSetNextPageID(int32 next_page_id) { #endif } -// TODO(port) -#if defined(OS_WIN) -void RenderThread::OnCreateNewView(HWND parent_hwnd, - HANDLE modal_dialog_event, +void RenderThread::OnCreateNewView(gfx::NativeViewId parent_hwnd, + ModalDialogEvent modal_dialog_event, const WebPreferences& webkit_prefs, int32 view_id) { + base::WaitableEvent* waitable_event = new base::WaitableEvent( +#if defined(OS_WIN) + modal_dialog_event.event); +#else + true, false); +#endif + // TODO(darin): once we have a RenderThread per RenderView, this will need to // change to assert that we are not creating more than one view. - base::WaitableEvent* waitable_event = - new base::WaitableEvent(modal_dialog_event); RenderView::Create( this, parent_hwnd, waitable_event, MSG_ROUTING_NONE, webkit_prefs, new SharedRenderViewCounter(0), view_id); } -#endif void RenderThread::OnSetCacheCapacities(size_t min_dead_capacity, size_t max_dead_capacity, |