diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
| commit | 81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12 (patch) | |
| tree | 41b3caf1a55ba3cfa2f6cf13b0a5ce3d773d631f /chrome/renderer/render_thread.cc | |
| parent | 4f7f4854821e8e4933ad2c662bfd9417eb604a68 (diff) | |
| download | chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.zip chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.gz chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.bz2 | |
Use lock-free lazy initialization for static histogram references
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_thread.cc')
| -rw-r--r-- | chrome/renderer/render_thread.cc | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/renderer/render_thread.cc b/chrome/renderer/render_thread.cc index 77b6fcc..456bedf 100644 --- a/chrome/renderer/render_thread.cc +++ b/chrome/renderer/render_thread.cc @@ -798,13 +798,9 @@ static void* CreateHistogram( const char *name, int min, int max, size_t buckets) { if (min <= 0) min = 1; - scoped_refptr<base::Histogram> histogram = base::Histogram::FactoryGet( + base::Histogram* histogram = base::Histogram::FactoryGet( name, min, max, buckets, base::Histogram::kUmaTargetedHistogramFlag); - // We'll end up leaking these histograms, unless there is some code hiding in - // there to do the dec-ref. - // TODO(jar): Handle reference counting in webkit glue. - histogram->AddRef(); - return histogram.get(); + return histogram; } static void AddHistogramSample(void* hist, int sample) { |