diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 22:32:21 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-28 22:32:21 +0000 |
commit | 12636df0dcf36c769c8a5940d6a0c0b6b6a6647c (patch) | |
tree | 5ff7eccca7457afe24c47a277286c834108e825c /chrome/renderer/render_thread.h | |
parent | ca3f22c070a6b61a3ec40ace07244890bbdd6ebe (diff) | |
download | chromium_src-12636df0dcf36c769c8a5940d6a0c0b6b6a6647c.zip chromium_src-12636df0dcf36c769c8a5940d6a0c0b6b6a6647c.tar.gz chromium_src-12636df0dcf36c769c8a5940d6a0c0b6b6a6647c.tar.bz2 |
Fix deadlock when plugin puts an alert and right afterwards the browser process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process.
BUG=23147
TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser.
Review URL: http://codereview.chromium.org/243018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_thread.h')
-rw-r--r-- | chrome/renderer/render_thread.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/renderer/render_thread.h b/chrome/renderer/render_thread.h index 9fa7203..5be1585 100644 --- a/chrome/renderer/render_thread.h +++ b/chrome/renderer/render_thread.h @@ -29,7 +29,6 @@ class SkBitmap; class UserScriptSlave; class URLPattern; -struct ModalDialogEvent; struct RendererPreferences; struct WebPreferences; @@ -152,7 +151,6 @@ class RenderThread : public RenderThreadBase, void OnSetNextPageID(int32 next_page_id); void OnSetCSSColors(const std::vector<CSSColors::CSSColorMapping>& colors); void OnCreateNewView(gfx::NativeViewId parent_hwnd, - ModalDialogEvent modal_dialog_event, const RendererPreferences& renderer_prefs, const WebPreferences& webkit_prefs, int32 view_id); |