diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:45:55 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:45:55 +0000 |
| commit | 503b1574e293e27e90b8d009ea1cec56961e7907 (patch) | |
| tree | 9b29fcc9cb049c125ee2f9472accc6381042d18b /chrome/renderer/render_thread.h | |
| parent | be9827184d20dea9dd7b7bfaa6e727e34af59d9d (diff) | |
| download | chromium_src-503b1574e293e27e90b8d009ea1cec56961e7907.zip chromium_src-503b1574e293e27e90b8d009ea1cec56961e7907.tar.gz chromium_src-503b1574e293e27e90b8d009ea1cec56961e7907.tar.bz2 | |
Revert 40490 - Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/660439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40494 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_thread.h')
| -rw-r--r-- | chrome/renderer/render_thread.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/chrome/renderer/render_thread.h b/chrome/renderer/render_thread.h index 2aaf768..a7ad1fb 100644 --- a/chrome/renderer/render_thread.h +++ b/chrome/renderer/render_thread.h @@ -52,12 +52,6 @@ class WebStorageEventDispatcher; // The RenderThreadBase is the minimal interface that a RenderView/Widget // expects from a render thread. The interface basically abstracts a way to send // and receive messages. -// -// TODO(brettw) this should be refactored like RenderProcess/RenderProcessImpl: -// This class should be named RenderThread and the implementation below should -// be RenderThreadImpl. The ::current() getter on the impl should then be moved -// here so we can provide another implementation of RenderThread for tests -// without having to check for NULL all the time. class RenderThreadBase { public: virtual ~RenderThreadBase() {} @@ -97,10 +91,6 @@ class RenderThread : public RenderThreadBase, // Returns the one render thread for this process. Note that this should only // be accessed when running on the render thread itself - // - // TODO(brettw) this should be on the abstract base class instead of here, - // and return the base class' interface instead. Currently this causes - // problems with testing. See the comment above RenderThreadBase above. static RenderThread* current(); // Returns the routing ID of the RenderWidget containing the current script |