diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 19:28:06 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 19:28:06 +0000 |
| commit | 573c1c27417914a7f212bb502c479d1cf315b6d3 (patch) | |
| tree | 1eebe88cc2ac16cc6cc405bd869dc7156cba67b7 /chrome/renderer/render_view.cc | |
| parent | 8a1f331497a81bb929ab75a3cfc8b1b835e21bcd (diff) | |
| download | chromium_src-573c1c27417914a7f212bb502c479d1cf315b6d3.zip chromium_src-573c1c27417914a7f212bb502c479d1cf315b6d3.tar.gz chromium_src-573c1c27417914a7f212bb502c479d1cf315b6d3.tar.bz2 | |
AutoFill sending forms should include elements with autoComplete="off" attributes.
On these pages we were hitting the DCHECK_EQ in autofill_manager.cc:237 when filling these forms. This was due to the lack of <input> elements with
autoComplete="off" attributes set when originally sending the form data with the RenderView::SendForms() call. This changes the renderer to add
these elements when originally sent and processed by the AutoFillManager::FormsSeen() call.
BUG=40700, 41702
TEST=Manual tests of pages in bug reports.
Review URL: http://codereview.chromium.org/2135012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48174 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_view.cc')
| -rw-r--r-- | chrome/renderer/render_view.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc index e9bd104..ac7d9b5 100644 --- a/chrome/renderer/render_view.cc +++ b/chrome/renderer/render_view.cc @@ -4722,12 +4722,8 @@ void RenderView::SendForms(WebFrame* frame) { const WebFormElement& web_form = web_forms[i]; FormData form; - FormManager::RequirementsMask requirements = - static_cast<FormManager::RequirementsMask>( - FormManager::REQUIRE_AUTOCOMPLETE | - FormManager::REQUIRE_ELEMENTS_ENABLED); if (FormManager::WebFormElementToFormData( - web_form, requirements, false, &form)) + web_form, FormManager::REQUIRE_NONE, false, &form)) forms.push_back(form); } |