diff options
| author | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-09 00:02:24 +0000 |
|---|---|---|
| committer | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-09 00:02:24 +0000 |
| commit | 2533ce1803f3324e69134e93f59acbb44afb1aa2 (patch) | |
| tree | 59f0afeb73854fcfe39ae92ae7f8df07c9d24526 /chrome/renderer/render_view.cc | |
| parent | def2c34edce5346ea285d47c3653c5d4192b406e (diff) | |
| download | chromium_src-2533ce1803f3324e69134e93f59acbb44afb1aa2.zip chromium_src-2533ce1803f3324e69134e93f59acbb44afb1aa2.tar.gz chromium_src-2533ce1803f3324e69134e93f59acbb44afb1aa2.tar.bz2 | |
Defer window.close(), resizeTo() and moveTo() actions
by posting a task back to the message loop before notifying
the RenderWidgetHost to perform these operations.
Otherwise the JS code races with the browser to use the
modified window.
BUG=http://crbug.com/6377
BUG=http://crbug.com/6192
Cache a pending_window_rect on the render_view (moved from
prior CL where I had it on the chrome_client_impl). This
is a short lived cache, and not a complete solution. It
fixes this case, where a JS script makes multiple operations
and expects the GetWindowSize() to be correct immedately
after having called SetWindowSize().
BUG=http://crbug.com/835
Review URL: http://codereview.chromium.org/115030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15698 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_view.cc')
| -rw-r--r-- | chrome/renderer/render_view.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc index 2b3c250..d0f0c74 100644 --- a/chrome/renderer/render_view.cc +++ b/chrome/renderer/render_view.cc @@ -1948,6 +1948,7 @@ void RenderView::Show(WebWidget* webwidget, WindowOpenDisposition disposition) { // browser process will impose a default position otherwise. Send(new ViewHostMsg_ShowView(opener_id_, routing_id_, disposition, initial_pos_, opened_by_user_gesture_, creator_url_)); + SetPendingWindowRect(initial_pos_); } void RenderView::CloseWidgetSoon(WebWidget* webwidget) { |