diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-16 11:09:42 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-16 11:09:42 +0000 |
| commit | 373e49d167befd846fe5e81e95fa80c825850619 (patch) | |
| tree | f9c8d6ef0f7083f3513ab7c9b5efc71291136c01 /chrome/renderer/render_view_browsertest.cc | |
| parent | 1a651480aa046ae9299238fc5318551b0e81e3c7 (diff) | |
| download | chromium_src-373e49d167befd846fe5e81e95fa80c825850619.zip chromium_src-373e49d167befd846fe5e81e95fa80c825850619.tar.gz chromium_src-373e49d167befd846fe5e81e95fa80c825850619.tar.bz2 | |
Revert 68905 - Pull in a named constant from WebKit
Reason: It broke the Win Builder (dbg)(shared), aka. shared_library bot.
Search for defaultMaxLength on:
http://build.chromium.org/p/chromium/builders/Win%20Builder%20(dbg)(shared)/builds/9/steps/compile/logs/stdio
Review URL: http://codereview.chromium.org/5770002
BUG=none
TEST=none
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/5891003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69392 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_view_browsertest.cc')
| -rw-r--r-- | chrome/renderer/render_view_browsertest.cc | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/chrome/renderer/render_view_browsertest.cc b/chrome/renderer/render_view_browsertest.cc index 6a596b5..f7f58c8 100644 --- a/chrome/renderer/render_view_browsertest.cc +++ b/chrome/renderer/render_view_browsertest.cc @@ -38,6 +38,13 @@ using WebKit::WebURLError; using webkit_glue::FormData; using webkit_glue::FormField; +namespace { + +// TODO(isherman): Pull this as a named constant from WebKit +const int kDefaultMaxLength = 0x80000; + +} // namespace + // Test that we get form state change notifications when input fields change. TEST_F(RenderViewTest, OnNavStateChanged) { // Don't want any delay for form state sync changes. This will still post a @@ -1032,14 +1039,14 @@ TEST_F(RenderViewTest, SendForms) { ASCIIToUTF16("firstname"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << forms[0].fields[0]; EXPECT_TRUE(forms[0].fields[1].StrictlyEqualsHack( FormField(string16(), ASCIIToUTF16("middlename"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << forms[0].fields[1]; EXPECT_TRUE(forms[0].fields[2].StrictlyEqualsHack( FormField(string16(), @@ -1078,14 +1085,14 @@ TEST_F(RenderViewTest, SendForms) { ASCIIToUTF16("firstname"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << form2.fields[0]; EXPECT_TRUE(form2.fields[1].StrictlyEqualsHack( FormField(string16(), ASCIIToUTF16("middlename"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << form2.fields[1]; EXPECT_TRUE(form2.fields[2].StrictlyEqualsHack( FormField(string16(), @@ -1122,14 +1129,14 @@ TEST_F(RenderViewTest, FillFormElement) { ASCIIToUTF16("firstname"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << forms[0].fields[0]; EXPECT_TRUE(forms[0].fields[1].StrictlyEqualsHack( FormField(string16(), ASCIIToUTF16("middlename"), string16(), ASCIIToUTF16("text"), - WebInputElement::defaultMaxLength, + kDefaultMaxLength, false))) << forms[0].fields[1]; // Verify that |didAcceptAutoFillSuggestion()| sets the value of the expected |