diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 14:59:33 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 14:59:33 +0000 |
| commit | e6e1501235c39803ea97000a94f9cd9f00de303e (patch) | |
| tree | 89fff8c96109b58f9870ec5fc1cbf62d5274a7a7 /chrome/renderer/render_view_unittest_mac.mm | |
| parent | c7c9b8ff8028602c0f39f4e12af4976f06cc1f30 (diff) | |
| download | chromium_src-e6e1501235c39803ea97000a94f9cd9f00de303e.zip chromium_src-e6e1501235c39803ea97000a94f9cd9f00de303e.tar.gz chromium_src-e6e1501235c39803ea97000a94f9cd9f00de303e.tar.bz2 | |
Address review comments.
Belongs to http://codereview.chromium.org/254002
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27609 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_view_unittest_mac.mm')
| -rw-r--r-- | chrome/renderer/render_view_unittest_mac.mm | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/chrome/renderer/render_view_unittest_mac.mm b/chrome/renderer/render_view_unittest_mac.mm index e146f1e..c2c766f 100644 --- a/chrome/renderer/render_view_unittest_mac.mm +++ b/chrome/renderer/render_view_unittest_mac.mm @@ -12,12 +12,16 @@ #include <Carbon/Carbon.h> // for the kVK_* constants. NSEvent* CmdDeadKeyEvent(NSEventType type, unsigned short code) { - UniChar uniChar = 0; switch(code) { - case kVK_UpArrow: uniChar = NSUpArrowFunctionKey; break; - case kVK_DownArrow: uniChar = NSDownArrowFunctionKey; break; - default: CHECK(false); + case kVK_UpArrow: + uniChar = NSUpArrowFunctionKey; + break; + case kVK_DownArrow: + uniChar = NSDownArrowFunctionKey; + break; + default: + CHECK(false); } NSString* s = [NSString stringWithFormat:@"%C", uniChar]; @@ -36,7 +40,6 @@ NSEvent* CmdDeadKeyEvent(NSEventType type, unsigned short code) { // Test that cmd-up/down scrolls the page exactly if it is not intercepted by // javascript. TEST_F(RenderViewTest, MacTestCmdUp) { - // Some preprocessor trickery so that we can have literal html in our source, // makes it easier to copy html to and from an html file for testing (the // preprocessor will remove the newlines at the line ends, turning this into |