diff options
| author | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 16:58:49 +0000 |
|---|---|---|
| committer | jcivelli@google.com <jcivelli@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 16:58:49 +0000 |
| commit | 08e9e134bca95868aa4679b67b4c7a4e1695fced (patch) | |
| tree | eed4bcda9a1cee28a7c3748fe9b363d66919d643 /chrome/renderer/render_widget.cc | |
| parent | c001c4c5277e933720fdd4a2dedd152d10de118a (diff) | |
| download | chromium_src-08e9e134bca95868aa4679b67b4c7a4e1695fced.zip chromium_src-08e9e134bca95868aa4679b67b4c7a4e1695fced.tar.gz chromium_src-08e9e134bca95868aa4679b67b4c7a4e1695fced.tar.bz2 | |
Cleaning up the node focus notification.
The notification that the focus changed in the page now uses webkit::WebViewClient::focusedNodeChanged() implemented by RenderView.
It was previously relying on the more general webkit::WebWidgetClient::didFocus() implemented in RenderWidget. (that should ideally only be fired when the frame gets focused, not everytime the focus in the frame changes).
BUG=None
TEST=Interactive UI tests should still pass (especially BrowserFocus*)
Review URL: http://codereview.chromium.org/2301001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48638 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_widget.cc')
| -rw-r--r-- | chrome/renderer/render_widget.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/renderer/render_widget.cc b/chrome/renderer/render_widget.cc index c4656f7..fe0d3c1 100644 --- a/chrome/renderer/render_widget.cc +++ b/chrome/renderer/render_widget.cc @@ -637,12 +637,6 @@ void RenderWidget::show(WebNavigationPolicy) { } void RenderWidget::didFocus() { - // Note that didFocus() is invoked everytime a new node is focused in the - // page. It could be expected that it would be called only when the widget - // gets the focus. If the current behavior was to change in WebKit for the - // expected one, the following notification would not work anymore. - Send(new ViewHostMsg_FocusedNodeChanged(routing_id_)); - // Prevent the widget from stealing the focus if it does not have focus // already. We do this by explicitely setting the focus to false again. // We only let the browser focus the renderer. |