diff options
author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-25 19:27:03 +0000 |
---|---|---|
committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-25 19:27:03 +0000 |
commit | 692eae7e273b3e136c4923197f917b5e538beed3 (patch) | |
tree | 15df23df48c3e1629190afe9f7c6f0d38445c94a /chrome/renderer/render_widget.cc | |
parent | a53870bb02901bcc9a4c0967bb6d1de338dfaa46 (diff) | |
download | chromium_src-692eae7e273b3e136c4923197f917b5e538beed3.zip chromium_src-692eae7e273b3e136c4923197f917b5e538beed3.tar.gz chromium_src-692eae7e273b3e136c4923197f917b5e538beed3.tar.bz2 |
Revert 24227 - Modify the RenderThread to track the number of widgets
and "hidden widgets" which are running through that thread.
By knowing the if the widgets are all hidden, the thread
can accurately inform V8 when it is idle so that V8 can
better cleanup unused memory when idle.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174303
TBR=mbelshe@google.com
Review URL: http://codereview.chromium.org/174417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_widget.cc')
-rw-r--r-- | chrome/renderer/render_widget.cc | 22 |
1 files changed, 4 insertions, 18 deletions
diff --git a/chrome/renderer/render_widget.cc b/chrome/renderer/render_widget.cc index cd722ba..863e73d 100644 --- a/chrome/renderer/render_widget.cc +++ b/chrome/renderer/render_widget.cc @@ -180,10 +180,8 @@ void RenderWidget::OnClose() { closing_ = true; // Browser correspondence is no longer needed at this point. - if (routing_id_ != MSG_ROUTING_NONE) { + if (routing_id_ != MSG_ROUTING_NONE) render_thread_->RemoveRoute(routing_id_); - SetHidden(false); - } // If there is a Send call on the stack, then it could be dangerous to close // now. Post a task that only gets invoked when there are no nested message @@ -205,7 +203,7 @@ void RenderWidget::OnResize(const gfx::Size& new_size, resizer_rect_ = resizer_rect; // TODO(darin): We should not need to reset this here. - SetHidden(false); + is_hidden_ = false; needs_repainting_on_restore_ = false; // We shouldn't be asked to resize to our current size. @@ -234,7 +232,7 @@ void RenderWidget::OnResize(const gfx::Size& new_size, void RenderWidget::OnWasHidden() { // Go into a mode where we stop generating paint and scrolling events. - SetHidden(true); + is_hidden_ = true; } void RenderWidget::OnWasRestored(bool needs_repainting) { @@ -243,7 +241,7 @@ void RenderWidget::OnWasRestored(bool needs_repainting) { return; // See OnWasHidden - SetHidden(false); + is_hidden_ = false; if (!needs_repainting && !needs_repainting_on_restore_) return; @@ -738,18 +736,6 @@ void RenderWidget::OnSetTextDirection(WebTextDirection direction) { webwidget_->setTextDirection(direction); } -void RenderWidget::SetHidden(bool hidden) { - if (is_hidden_ == hidden) - return; - - // The status has changed. Tell the RenderThread about it. - is_hidden_ = hidden; - if (is_hidden_) - render_thread_->WidgetHidden(); - else - render_thread_->WidgetRestored(); -} - void RenderWidget::SetBackground(const SkBitmap& background) { background_ = background; // Generate a full repaint. |