diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:03:22 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:03:22 +0000 |
| commit | 396c3a461549b02dcb830a287ac4656b2ca181e7 (patch) | |
| tree | dfd70c68c3fc4aa501a8f1bf13bf4853d2f7faef /chrome/renderer/render_widget.cc | |
| parent | 29a694916746e366724f7ac6f9aa0d103894f4a9 (diff) | |
| download | chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.zip chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.tar.gz chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.tar.bz2 | |
Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40490 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_widget.cc')
| -rw-r--r-- | chrome/renderer/render_widget.cc | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/chrome/renderer/render_widget.cc b/chrome/renderer/render_widget.cc index 343db541..03fbbd7 100644 --- a/chrome/renderer/render_widget.cc +++ b/chrome/renderer/render_widget.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -15,6 +15,7 @@ #include "chrome/common/render_messages.h" #include "chrome/common/transport_dib.h" #include "chrome/renderer/render_process.h" +#include "chrome/renderer/render_thread.h" #include "skia/ext/platform_canvas.h" #include "third_party/skia/include/core/SkShader.h" #include "third_party/WebKit/WebKit/chromium/public/WebCursorInfo.h" @@ -270,8 +271,8 @@ void RenderWidget::OnUpdateRectAck() { current_paint_buf_ = NULL; } - // Notify subclasses - DidPaint(); + // Notify subclasses. + DidFlushPaint(); // Continue painting if necessary... CallDoDeferredUpdate(); @@ -497,6 +498,9 @@ void RenderWidget::DoDeferredUpdate() { next_paint_flags_ = 0; UpdateIME(); + + // Let derived classes know we've painted. + DidInitiatePaint(); } /////////////////////////////////////////////////////////////////////////////// |