diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:03:22 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 05:03:22 +0000 |
| commit | 396c3a461549b02dcb830a287ac4656b2ca181e7 (patch) | |
| tree | dfd70c68c3fc4aa501a8f1bf13bf4853d2f7faef /chrome/renderer/render_widget.h | |
| parent | 29a694916746e366724f7ac6f9aa0d103894f4a9 (diff) | |
| download | chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.zip chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.tar.gz chromium_src-396c3a461549b02dcb830a287ac4656b2ca181e7.tar.bz2 | |
Make the pepper 2D flush callback actually function as advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40490 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_widget.h')
| -rw-r--r-- | chrome/renderer/render_widget.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/renderer/render_widget.h b/chrome/renderer/render_widget.h index ab591f0..dab2a81 100644 --- a/chrome/renderer/render_widget.h +++ b/chrome/renderer/render_widget.h @@ -161,9 +161,12 @@ class RenderWidget : public IPC::Channel::Listener, void OnMsgRepaint(const gfx::Size& size_to_paint); void OnSetTextDirection(WebKit::WebTextDirection direction); - // Override point to notify that a paint has happened. This fires after the - // browser side has updated the screen for a newly painted region. - virtual void DidPaint() {} + // Override point to notify derived classes that a paint has happened. + // DidInitiatePaint happens when we've generated a new bitmap and sent it to + // the browser. DidFlushPaint happens once we've received the ACK that the + // screen has actually been updated. + virtual void DidInitiatePaint() {} + virtual void DidFlushPaint() {} // Sets the "hidden" state of this widget. All accesses to is_hidden_ should // use this method so that we can properly inform the RenderThread of our |