diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 20:21:11 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 20:21:11 +0000 |
commit | cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb (patch) | |
tree | e4f752f4fa1c3985abe91af25e7918c90a59768f /chrome/renderer/render_widget.h | |
parent | 9b341774ce43e4034ac4465997b31e7b15fa1928 (diff) | |
download | chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.zip chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.tar.gz chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.tar.bz2 |
The popup for autofill is now never activated, even when clicked.
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer).
Most of the file changes are just renaming focus_on_show to activatable.
TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/render_widget.h')
-rw-r--r-- | chrome/renderer/render_widget.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/renderer/render_widget.h b/chrome/renderer/render_widget.h index dfdb825..2ee001d 100644 --- a/chrome/renderer/render_widget.h +++ b/chrome/renderer/render_widget.h @@ -32,7 +32,7 @@ class RenderWidget : public IPC::Channel::Listener, // RenderThreadBase implementation, mostly commonly g_render_thread. static RenderWidget* Create(int32 opener_id, RenderThreadBase* render_thread, - bool focus_on_show); + bool activatable); // The routing ID assigned by the RenderProcess. Will be MSG_ROUTING_NONE if // not yet assigned a view ID, in which case, the process MUST NOT send @@ -89,7 +89,7 @@ class RenderWidget : public IPC::Channel::Listener, // without ref-counting is an error. friend class base::RefCounted<RenderWidget>; - RenderWidget(RenderThreadBase* render_thread, bool focus_on_show); + RenderWidget(RenderThreadBase* render_thread, bool activatable); virtual ~RenderWidget(); // Initializes this view with the given opener. CompleteInit must be called @@ -265,8 +265,8 @@ class RenderWidget : public IPC::Channel::Listener, bool ime_control_updated_; bool ime_control_busy_; - // Whether the window for this RenderWidget should be focused when shown. - bool focus_on_show_; + // Whether the window for this RenderWidget can be activated. + bool activatable_; // Holds all the needed plugin window moves for a scroll. std::vector<WebPluginGeometry> plugin_window_moves_; |