summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/renderer_histogram_snapshots.h
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-28 22:02:46 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-28 22:02:46 +0000
commitc9a3ef84a7d486d4dd24fe8332b8b83ed833885d (patch)
treee1180399782984b4f1ffd909be6149c5ce1cc736 /chrome/renderer/renderer_histogram_snapshots.h
parentc2a44c4852ad9f800968dcc32e3344c948c2bc88 (diff)
downloadchromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.zip
chromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.tar.gz
chromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.tar.bz2
Automatically adapt to faster/slower uploads of renderer histograms
This replaces the current time based approach (chrome is given N seconds to upload all renederer histograms) with an asynch callback approach that waits until all renderers have responded (with their updates). It uses a fall-back timer to ensure that a hung renderer won't delay things forever as well. This causes faster (and complete) updates in about:histograms as well as generally assuring complete updates during UMA gatherings. This code was contributed by Raman Tenneti in CL 42496 http://codereview.chromium.org/42496 bug=12850 r=raman Review URL: http://codereview.chromium.org/113473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/renderer_histogram_snapshots.h')
-rw-r--r--chrome/renderer/renderer_histogram_snapshots.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/renderer/renderer_histogram_snapshots.h b/chrome/renderer/renderer_histogram_snapshots.h
index 5c9f93a..0a1238c 100644
--- a/chrome/renderer/renderer_histogram_snapshots.h
+++ b/chrome/renderer/renderer_histogram_snapshots.h
@@ -24,7 +24,7 @@ class RendererHistogramSnapshots {
~RendererHistogramSnapshots() {}
// Send the histogram data.
- void SendHistograms();
+ void SendHistograms(int sequence_number);
// Maintain a map of histogram names to the sample stats we've sent.
typedef std::map<std::string, Histogram::SampleSet> LoggedSampleMap;
@@ -33,7 +33,7 @@ class RendererHistogramSnapshots {
private:
// Extract snapshot data and then send it off the the Browser process.
// Send only a delta to what we have already sent.
- void UploadAllHistrograms();
+ void UploadAllHistrograms(int sequence_number);
void UploadHistrogram(const Histogram& histogram,
HistogramPickledList* histograms);
void UploadHistogramDelta(const Histogram& histogram,