The final step in making session storage cross-process. Remove dead code and do a bit of refactoring. Use the recently added session_storage_namespace_id_.

Next steps: a bit more testing then I think we're ready to take it out from behind its flag!

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/523117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36611 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 13 deletions

diff --git a/chrome/renderer/renderer_webstoragenamespace_impl.cc b/chrome/renderer/renderer_webstoragenamespace_impl.cc
index 7bd704f..d5146e7f 100644
--- a/chrome/renderer/renderer_webstoragenamespace_impl.cc
+++ b/chrome/renderer/renderer_webstoragenamespace_impl.cc
@@ -14,16 +14,16 @@ using WebKit::WebString;
 
 RendererWebStorageNamespaceImpl::RendererWebStorageNamespaceImpl(
     DOMStorageType storage_type)
-    : storage_type_(storage_type) {
-  RenderThread::current()->Send(
-        new ViewHostMsg_DOMStorageNamespaceId(storage_type_,
-                                              &namespace_id_));
+    : storage_type_(storage_type),
+      namespace_id_(kLocalStorageNamespaceId) {
+  DCHECK(storage_type == DOM_STORAGE_LOCAL);
 }
 
 RendererWebStorageNamespaceImpl::RendererWebStorageNamespaceImpl(
     DOMStorageType storage_type, int64 namespace_id)
     : storage_type_(storage_type),
       namespace_id_(namespace_id) {
+  DCHECK(storage_type == DOM_STORAGE_SESSION);
 }
 
 RendererWebStorageNamespaceImpl::~RendererWebStorageNamespaceImpl() {
@@ -33,19 +33,14 @@ WebStorageArea* RendererWebStorageNamespaceImpl::createStorageArea(
     const WebString& origin) {
   // Ideally, we'd keep a hash map of origin to these objects.  Unfortunately
   // this doesn't seem practical because there's no good way to ref-count these
-  // objects, and it'd be unclear who owned them.  So, instead, we'll pay a
-  // price for an allocaiton and IPC for each.
+  // objects, and it'd be unclear who owned them.  So, instead, we'll pay the
+  // price in terms of wasted memory.
   return new RendererWebStorageAreaImpl(namespace_id_, origin);
 }
 
 WebStorageNamespace* RendererWebStorageNamespaceImpl::copy() {
-  // This cannot easily be deferred because we need a snapshot in time.
-  int64 new_namespace_id;
-  RenderThread::current()->Send(
-      new ViewHostMsg_DOMStorageCloneNamespaceId(namespace_id_,
-                                                 &new_namespace_id));
-  return new RendererWebStorageNamespaceImpl(storage_type_,
-                                             new_namespace_id);
+  NOTREACHED();  // We shouldn't ever reach this code in Chromium.
+  return NULL;
 }
 
 void RendererWebStorageNamespaceImpl::close() {