Use Value objects instead of JSON strings in extension API response IPCs.

When we're sending the result of an extension API method call, we currently
convert a Value object into a JSON string in the browser process, and then call
JSON.parse in javascript on the renderer side. This CL changes that to pass the
Value object in the IPC, and uses V8ValueConverter to turn the Value into the
appropriate v8 native object, avoiding the need to parse JSON.

This is a first step towards supporting binary data for API request
parameters and responses.

BUG=122675
TEST=No new functionality ; existing unit and browser tests should still pass.

Review URL: https://chromiumcodereview.appspot.com/10041047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133133 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 3 deletions

diff --git a/chrome/renderer/resources/extensions/send_request.js b/chrome/renderer/resources/extensions/send_request.js
index 3e47f40..045e270 100644
--- a/chrome/renderer/resources/extensions/send_request.js
+++ b/chrome/renderer/resources/extensions/send_request.js
@@ -29,7 +29,7 @@ chromeHidden.handleResponse = function(requestId, name,
 
     if (request.callback) {
       // Callbacks currently only support one callback argument.
-      var callbackArgs = response ? [chromeHidden.JSON.parse(response)] : [];
+      var callbackArgs = typeof(response) != "undefined" ? [response] : [];
 
       // Validate callback in debug only -- and only when the
       // caller has provided a callback. Implementations of api
@@ -44,7 +44,6 @@ chromeHidden.handleResponse = function(requestId, name,
           if (request.callbackSchema.parameters.length > 1) {
             throw new Error("Callbacks may only define one parameter");
           }
-
           chromeHidden.validate(callbackArgs,
               request.callbackSchema.parameters);
         } catch (exception) {
@@ -53,7 +52,7 @@ chromeHidden.handleResponse = function(requestId, name,
         }
       }
 
-      if (response) {
+      if (typeof(response) != "undefined") {
         request.callback(callbackArgs[0]);
       } else {
         request.callback();