diff options
| author | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-22 02:35:54 +0000 |
|---|---|---|
| committer | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-22 02:35:54 +0000 |
| commit | 31bbfd7310d8578a694564307310acf4a7161572 (patch) | |
| tree | 93dbc9d9076d6e5ffdbeaa779afb4b6ce75fe3b9 /chrome/renderer/resources/extensions/unload_event.js | |
| parent | b518fa10e24b183a15b8c194ddc09527c0d07768 (diff) | |
| download | chromium_src-31bbfd7310d8578a694564307310acf4a7161572.zip chromium_src-31bbfd7310d8578a694564307310acf4a7161572.tar.gz chromium_src-31bbfd7310d8578a694564307310acf4a7161572.tar.bz2 | |
Make the externally connectable browser test clobber all of the builtins,
except for a very small subset of them, and use the safe builtins to make the
test pass.
This will give us a decent sense of confidence that web pages can't
accidentally override builtins in a way that breaks us, though there are still
infinite ways for an extension to deliberately break itself.
BUG=55316
R=jyasskin@chromium.org
Review URL: https://codereview.chromium.org/17451011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207995 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/resources/extensions/unload_event.js')
| -rw-r--r-- | chrome/renderer/resources/extensions/unload_event.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/renderer/resources/extensions/unload_event.js b/chrome/renderer/resources/extensions/unload_event.js index 85a5465..52cf889 100644 --- a/chrome/renderer/resources/extensions/unload_event.js +++ b/chrome/renderer/resources/extensions/unload_event.js @@ -11,13 +11,13 @@ var listeners = []; exports.addListener = function(listener) { - listeners.push(listener); + $Array.push(listeners, listener); }; exports.removeListener = function(listener) { for (var i = 0; i < listeners.length; ++i) { if (listeners[i] == listener) { - listeners.splice(i, 1); + $Array.splice(listeners, i, 1); return; } } |