Changed the extension.connect() API not to broadcast to all tabs. Added a

more specific tabs.connect(tabId) API to connect to a specific tab.

Also changed the ExtensionMessageService from a singleton to a Profile-owned object.

BUG=12461
TEST=no

Review URL: http://codereview.chromium.org/155707

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21102 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 13 insertions, 1 deletions

diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index b9a0548..e702744 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -17,6 +17,7 @@ var chrome = chrome || {};
   native function GetViews();
   native function GetChromeHidden();
   native function GetNextRequestId();
+  native function OpenChannelToTab();
 
   if (!chrome)
     chrome = {};
@@ -304,6 +305,17 @@ var chrome = chrome || {};
     chrome.types.optFun
   ];
 
+  chrome.tabs.connect = function(tabId, opt_name) {
+    validate(arguments, arguments.callee.params);
+    var portId = OpenChannelToTab(tabId, chrome.extension.id_, opt_name || "");
+    return chromeHidden.Port.createPort(portId, opt_name);
+  };
+
+  chrome.tabs.connect.params = [
+    chrome.types.pInt,
+    chrome.types.optStr
+  ];
+
   // Sends ({Tab}).
   // Will *NOT* be followed by tab-attached - it is implied.
   // *MAY* be followed by tab-selection-changed.
@@ -531,7 +543,7 @@ var chrome = chrome || {};
     chrome.extension = new chrome.Extension(extensionId);
     // TODO(mpcomplete): self.onConnect is deprecated.  Remove it at 1.0.
     // http://code.google.com/p/chromium/issues/detail?id=16356
-    chrome.self.onConnect = new chrome.Event("channel-connect:" + extensionId);
+    chrome.self.onConnect = chrome.extension.onConnect;
 
     setupPageActionEvents(extensionId);
   });