Addition of a new parameter to the popup.show(...) Chrome extension API that allows the caller to specify the behaviour of the window focus when the pop-up is displayed.

I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test.  I also corrected a truncated string in the unit-test.

Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top.  If a window is shown and activated, it is automatically brought to the front.  Because we don't activate the pop-up when we want to keep the focus in the current extension view,  I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window.

BUG=none
TEST=ExtensionApiTest.FLAKY_Popup

Review URL: http://codereview.chromium.org/454019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 18 insertions, 6 deletions

diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index 2fdaad7..7d8cac8 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -425,19 +425,31 @@ var chrome = chrome || {};
         this.definition.parameters[0],
         {
           type: "object",
-          name: "domAnchor",
+          name: "showDetails",
           properties: {
-            top: { type: "integer", minimum: 0 },
-            left: { type: "integer", minimum: 0 },
-            width: { type: "integer", minimum: 0 },
-            height: { type: "integer", minimum: 0 }
+            domAnchor: {
+              type: "object",
+              properties: {
+                top: { type: "integer", minimum: 0 },
+                left: { type: "integer", minimum: 0 },
+                width: { type: "integer", minimum: 0 },
+                height: { type: "integer", minimum: 0 }
+              }
+            },
+            giveFocus: {
+              type: "boolean",
+              optional: true
+            }
           }
         },
         this.definition.parameters[2]
       ];
       return sendRequest(this.name,
                          [url,
-                          getAbsoluteRect(showDetails.relativeTo),
+                          {
+                            domAnchor: getAbsoluteRect(showDetails.relativeTo),
+                            giveFocus: showDetails.giveFocus
+                          },
                           callback],
                          internalSchema);
     }