summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
diff options
context:
space:
mode:
authorccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-19 01:02:21 +0000
committerccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-19 01:02:21 +0000
commit220454d186b388088f344890c1cd30a6c6174770 (patch)
treecd619234481b4f131fae94316a6b97e424e4b94d /chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
parentdf772c31fbca3ee58c3cfde539b751086a20a323 (diff)
downloadchromium_src-220454d186b388088f344890c1cd30a6c6174770.zip
chromium_src-220454d186b388088f344890c1cd30a6c6174770.tar.gz
chromium_src-220454d186b388088f344890c1cd30a6c6174770.tar.bz2
Remove blacklisting of Mac OS 10.6 and 10.7.
Add blacklisting of VMWare driver on 10.7 because it hangs. Disable compositing expectation test on 10.7 because it will give different results depending on whether it is running on a VM or real hardware. Expand disabling of PhishingClassifierTest.DisableDetection because it flakes on all Mac versions now. TBR=vangelis BUG=266186 Review URL: https://codereview.chromium.org/62333028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235863 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc')
-rw-r--r--chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc17
1 files changed, 6 insertions, 11 deletions
diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
index c9c689b..8c7409e 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
@@ -28,10 +28,6 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "url/gurl.h"
-#if defined(OS_MACOSX)
-#include "base/mac/mac_util.h"
-#endif
-
using ::testing::AllOf;
using ::testing::Contains;
using ::testing::Not;
@@ -272,15 +268,14 @@ IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, TestClassification) {
EXPECT_EQ(PhishingClassifier::kInvalidScore, phishy_score);
}
-IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, DisableDetection) {
+// This test flakes on Mac with force compositing mode for an unknown reason.
+// http://crbug.com/316709
#if defined(OS_MACOSX)
- if (base::mac::IsOSMountainLionOrLater()) {
- // This test flakes on 10.8 only for an unknown reason.
- // http://crbug.com/316709
- return;
- }
+#define MAYBE_DisableDetection DISABLED_DisableDetection
+#else
+#define MAYBE_DisableDetection DisableDetection
#endif
-
+IN_PROC_BROWSER_TEST_F(PhishingClassifierTest, MAYBE_DisableDetection) {
// No scorer yet, so the classifier is not ready.
EXPECT_FALSE(classifier_->is_ready());