diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 17:08:20 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 17:08:20 +0000 |
commit | 601858c0f72ea9693a4796fe6b48558efde46ed7 (patch) | |
tree | f9102a4e748ce2f2257f86a748ba6ecfb7087141 /chrome/renderer | |
parent | a0709c0dafd07a463a1e9b3553554a0be6cec862 (diff) | |
download | chromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.zip chromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.tar.gz chromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.tar.bz2 |
FBTF: Move more ctors/dtors from headers to implementation.
- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves
three megs off browser.a.
- Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only
shaved 100k off browser.a/renderer.a.
- Adding/Moving dtors of objects that used some form of base::*Timer<> was
negligible; there were only a few classes that had a Timer but had a
ctor/dtor in the header after the previous cleanups.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3278006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
-rw-r--r-- | chrome/renderer/net/renderer_net_predictor.cc | 3 | ||||
-rw-r--r-- | chrome/renderer/net/renderer_net_predictor.h | 3 | ||||
-rw-r--r-- | chrome/renderer/translate_helper.cc | 3 | ||||
-rw-r--r-- | chrome/renderer/translate_helper.h | 2 | ||||
-rw-r--r-- | chrome/renderer/user_script_idle_scheduler.cc | 3 | ||||
-rw-r--r-- | chrome/renderer/user_script_idle_scheduler.h | 1 |
6 files changed, 12 insertions, 3 deletions
diff --git a/chrome/renderer/net/renderer_net_predictor.cc b/chrome/renderer/net/renderer_net_predictor.cc index 7749e91..7f9a7f1 100644 --- a/chrome/renderer/net/renderer_net_predictor.cc +++ b/chrome/renderer/net/renderer_net_predictor.cc @@ -32,6 +32,9 @@ RendererNetPredictor::RendererNetPredictor() Reset(); } +RendererNetPredictor::~RendererNetPredictor() { +} + void RendererNetPredictor::Reset() { domain_map_.clear(); c_string_queue_.Clear(); diff --git a/chrome/renderer/net/renderer_net_predictor.h b/chrome/renderer/net/renderer_net_predictor.h index 36c2400..b761763 100644 --- a/chrome/renderer/net/renderer_net_predictor.h +++ b/chrome/renderer/net/renderer_net_predictor.h @@ -36,8 +36,7 @@ void DnsPrefetchCString(const char* hostname, size_t length); class RendererNetPredictor { public: RendererNetPredictor(); - - ~RendererNetPredictor() {} + ~RendererNetPredictor(); // Push a name into the queue to be resolved. void Resolve(const char* name, size_t length); diff --git a/chrome/renderer/translate_helper.cc b/chrome/renderer/translate_helper.cc index fafd52d..ab8bcdf 100644 --- a/chrome/renderer/translate_helper.cc +++ b/chrome/renderer/translate_helper.cc @@ -42,6 +42,9 @@ TranslateHelper::TranslateHelper(RenderView* render_view) ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)) { } +TranslateHelper::~TranslateHelper() { +} + void TranslateHelper::TranslatePage(int page_id, const std::string& source_lang, const std::string& target_lang, diff --git a/chrome/renderer/translate_helper.h b/chrome/renderer/translate_helper.h index 0e3a989..04c623e 100644 --- a/chrome/renderer/translate_helper.h +++ b/chrome/renderer/translate_helper.h @@ -23,7 +23,7 @@ class WebFrame; class TranslateHelper { public: explicit TranslateHelper(RenderView* render_view); - virtual ~TranslateHelper() {} + virtual ~TranslateHelper(); // Translates the page contents from |source_lang| to |target_lang|. // Does nothing if |page_id| is not the current page id. diff --git a/chrome/renderer/user_script_idle_scheduler.cc b/chrome/renderer/user_script_idle_scheduler.cc index 9336a9d..b2989a4 100644 --- a/chrome/renderer/user_script_idle_scheduler.cc +++ b/chrome/renderer/user_script_idle_scheduler.cc @@ -19,6 +19,9 @@ UserScriptIdleScheduler::UserScriptIdleScheduler(RenderView* view, frame_(frame), has_run_(false) { } +UserScriptIdleScheduler::~UserScriptIdleScheduler() { +} + void UserScriptIdleScheduler::DidFinishDocumentLoad() { MessageLoop::current()->PostDelayedTask(FROM_HERE, method_factory_.NewRunnableMethod(&UserScriptIdleScheduler::MaybeRun), diff --git a/chrome/renderer/user_script_idle_scheduler.h b/chrome/renderer/user_script_idle_scheduler.h index 012f6f6..d287d75 100644 --- a/chrome/renderer/user_script_idle_scheduler.h +++ b/chrome/renderer/user_script_idle_scheduler.h @@ -27,6 +27,7 @@ class WebFrame; class UserScriptIdleScheduler { public: UserScriptIdleScheduler(RenderView* view, WebKit::WebFrame* frame); + ~UserScriptIdleScheduler(); bool has_run() { return has_run_; } |