summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-05 00:10:06 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-05 00:10:06 +0000
commited4bf2dbceed9daaf6401e6e65701d4e51798953 (patch)
tree0b1f193c8a0b77b47424508d1b7c35ff03f13d6d /chrome/renderer
parentb42850f1e2b9875f491be41154cf23e773894ba3 (diff)
downloadchromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.zip
chromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.tar.gz
chromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.tar.bz2
Various trivial clean-up bits:
* Fix an 80-column issue * Remove an unused param * Remove an unnecessary setter * Fix a variable capitalization style violation Review URL: http://codereview.chromium.org/100361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
-rw-r--r--chrome/renderer/render_view.cc6
-rw-r--r--chrome/renderer/render_view.h6
2 files changed, 4 insertions, 8 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 112ef78..919a248 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -1804,7 +1804,7 @@ WebView* RenderView::CreateWebView(WebView* webview, bool user_gesture) {
NULL, waitable_event, routing_id_,
prefs, shared_popup_counter_,
routing_id);
- view->set_opened_by_user_gesture(user_gesture);
+ view->opened_by_user_gesture_ = user_gesture;
// Copy over the alternate error page URL so we can have alt error pages in
// the new render view (we don't need the browser to send the URL back down).
@@ -1949,7 +1949,7 @@ void RenderView::Show(WebWidget* webwidget, WindowOpenDisposition disposition) {
// that's okay. It'll be ignored if disposition is not NEW_POPUP, or the
// browser process will impose a default position otherwise.
Send(new ViewHostMsg_ShowView(opener_id_, routing_id_, disposition,
- initial_pos_, WasOpenedByUserGesture(NULL)));
+ initial_pos_, opened_by_user_gesture_));
}
void RenderView::CloseWidgetSoon(WebWidget* webwidget) {
@@ -2281,7 +2281,7 @@ void RenderView::ReportFindInPageSelection(int request_id,
false));
}
-bool RenderView::WasOpenedByUserGesture(WebView* webview) const {
+bool RenderView::WasOpenedByUserGesture() const {
return opened_by_user_gesture_;
}
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index 17ae772..65fca92 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -300,7 +300,7 @@ class RenderView : public RenderWidget,
virtual void ReportFindInPageSelection(int request_id,
int active_match_ordinal,
const WebKit::WebRect& selection);
- virtual bool WasOpenedByUserGesture(WebView* webview) const;
+ virtual bool WasOpenedByUserGesture() const;
virtual void SpellCheck(const std::wstring& word, int& misspell_location,
int& misspell_length);
virtual void SetInputMethodState(bool enabled);
@@ -597,10 +597,6 @@ class RenderView : public RenderWidget,
// UI that is going to be hosted by this RenderView.
void CreateDevToolsClient();
- void set_opened_by_user_gesture(bool value) {
- opened_by_user_gesture_ = value;
- }
-
// Called by RenderWidget after it paints.
virtual void DidPaint();