diff options
| author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 20:44:57 +0000 |
|---|---|---|
| committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 20:44:57 +0000 |
| commit | 84734df4b93aa0e7d01313b17ff190022dcca8bf (patch) | |
| tree | da7382f66f3fee629292a93c3132ebe5d6375228 /chrome/renderer | |
| parent | 933743a07ca00a6b2503bb483cf50cc6c41c1d23 (diff) | |
| download | chromium_src-84734df4b93aa0e7d01313b17ff190022dcca8bf.zip chromium_src-84734df4b93aa0e7d01313b17ff190022dcca8bf.tar.gz chromium_src-84734df4b93aa0e7d01313b17ff190022dcca8bf.tar.bz2 | |
Autofill: Fix a leak.
Rewrote the comment to remove the use of a pronoun.
I'm slightly disturbed this wasn't caught by testing--the leak that is.
CID_COUNT=1
CID=104202
BUG=none
TEST=none
R=groby
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/10542103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141485 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
| -rw-r--r-- | chrome/renderer/autofill/password_generation_manager.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/renderer/autofill/password_generation_manager.cc b/chrome/renderer/autofill/password_generation_manager.cc index 829968a..beccc02 100644 --- a/chrome/renderer/autofill/password_generation_manager.cc +++ b/chrome/renderer/autofill/password_generation_manager.cc @@ -33,11 +33,11 @@ bool GetAccountCreationPasswordFields( if (form.isNull() || !form.autoComplete()) return false; - // If we can't get a valid PasswordForm, we skip this form because the - // the password won't get saved even if we generate it. - webkit::forms::PasswordForm* password_form( + // Bail out if |form| is not a valid PasswordForm. In this case the password + // wouldn't get saved even if generated. + scoped_ptr<webkit::forms::PasswordForm> password_form( webkit::forms::PasswordFormDomManager::CreatePasswordForm(form)); - if (!password_form) { + if (!password_form.get()) { DVLOG(2) << "Invalid action on form"; return false; } |