diff options
| author | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-22 20:54:00 +0000 |
|---|---|---|
| committer | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-22 20:54:00 +0000 |
| commit | be6d78c2e81d8f552c7e69131a187ddd58af9126 (patch) | |
| tree | 2244e96b97f9e1de02a68a25b775e96e14e26b1b /chrome/renderer | |
| parent | 8bb5f8ad91201a114a3b13d17f1931fb76b0b908 (diff) | |
| download | chromium_src-be6d78c2e81d8f552c7e69131a187ddd58af9126.zip chromium_src-be6d78c2e81d8f552c7e69131a187ddd58af9126.tar.gz chromium_src-be6d78c2e81d8f552c7e69131a187ddd58af9126.tar.bz2 | |
Move TranslateHelper creation into ChromeRenderViewObserver
TranslateHelper was created in ChromeContentRenderClient because
TranslateHelper required AutofillAgent instance originally. But, currently
it doesn't depend on it.
This change move the creation of TranslateHelper instance into
ChromeRenderViewObserver just for simplification.
There is no functional change.
BUG=n/a
TEST=build all components
Review URL: https://chromiumcodereview.appspot.com/12038017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178085 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
| -rw-r--r-- | chrome/renderer/chrome_content_renderer_client.cc | 4 | ||||
| -rw-r--r-- | chrome/renderer/chrome_render_view_observer.cc | 5 | ||||
| -rw-r--r-- | chrome/renderer/chrome_render_view_observer.h | 3 |
3 files changed, 4 insertions, 8 deletions
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc index ebdfd13..ffaa274 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -66,7 +66,6 @@ #include "chrome/renderer/searchbox/searchbox_extension.h" #include "chrome/renderer/spellchecker/spellcheck.h" #include "chrome/renderer/spellchecker/spellcheck_provider.h" -#include "chrome/renderer/translate_helper.h" #include "chrome/renderer/visitedlink_slave.h" #include "content/public/common/content_constants.h" #include "content/public/renderer/render_thread.h" @@ -312,10 +311,9 @@ void ChromeContentRendererClient::RenderViewCreated( page_click_tracker->AddListener(password_autofill_manager); page_click_tracker->AddListener(autofill_agent); - TranslateHelper* translate = new TranslateHelper(render_view); new ChromeRenderViewObserver( render_view, content_settings, chrome_observer_.get(), - extension_dispatcher_.get(), translate); + extension_dispatcher_.get()); #if defined(ENABLE_PLUGINS) new PepperHelper(render_view); diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc index dde8277..020979a 100644 --- a/chrome/renderer/chrome_render_view_observer.cc +++ b/chrome/renderer/chrome_render_view_observer.cc @@ -170,13 +170,12 @@ ChromeRenderViewObserver::ChromeRenderViewObserver( content::RenderView* render_view, ContentSettingsObserver* content_settings, ChromeRenderProcessObserver* chrome_render_process_observer, - extensions::Dispatcher* extension_dispatcher, - TranslateHelper* translate_helper) + extensions::Dispatcher* extension_dispatcher) : content::RenderViewObserver(render_view), chrome_render_process_observer_(chrome_render_process_observer), extension_dispatcher_(extension_dispatcher), content_settings_(content_settings), - translate_helper_(translate_helper), + translate_helper_(new TranslateHelper(render_view)), phishing_classifier_(NULL), last_indexed_page_id_(-1), allow_displaying_insecure_content_(false), diff --git a/chrome/renderer/chrome_render_view_observer.h b/chrome/renderer/chrome_render_view_observer.h index 292edaa..80247ff 100644 --- a/chrome/renderer/chrome_render_view_observer.h +++ b/chrome/renderer/chrome_render_view_observer.h @@ -48,8 +48,7 @@ class ChromeRenderViewObserver : public content::RenderViewObserver, content::RenderView* render_view, ContentSettingsObserver* content_settings, ChromeRenderProcessObserver* chrome_render_process_observer, - extensions::Dispatcher* extension_dispatcher, - TranslateHelper* translate_helper); + extensions::Dispatcher* extension_dispatcher); virtual ~ChromeRenderViewObserver(); private: |