Add undeclared virtual destructors part 4

Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.

These files were discovered using the -Wnon-virtual-dtor flag in g++.

r=jar
BUG=47469

Review URL: http://codereview.chromium.org/3032046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54408 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 6 insertions, 1 deletions

diff --git a/chrome/renderer/notification_provider.h b/chrome/renderer/notification_provider.h
index aa1d8f6..80ec832 100644
--- a/chrome/renderer/notification_provider.h
+++ b/chrome/renderer/notification_provider.h
@@ -23,7 +23,7 @@ class WebNotificationPermissionCallback;
 class NotificationProvider : public WebKit::WebNotificationPresenter {
  public:
   explicit NotificationProvider(RenderView* view);
-  ~NotificationProvider() {}
+  virtual ~NotificationProvider() {}
 
   // WebKit::WebNotificationPresenter interface.
   virtual bool show(const WebKit::WebNotification& proxy);
diff --git a/chrome/renderer/pepper_plugin_delegate_impl.h b/chrome/renderer/pepper_plugin_delegate_impl.h
index 5b208e9..fa9fa91 100644
--- a/chrome/renderer/pepper_plugin_delegate_impl.h
+++ b/chrome/renderer/pepper_plugin_delegate_impl.h
@@ -24,6 +24,7 @@ class PepperPluginDelegateImpl
       public base::SupportsWeakPtr<PepperPluginDelegateImpl> {
  public:
   explicit PepperPluginDelegateImpl(RenderView* render_view);
+  virtual ~PepperPluginDelegateImpl() {}
 
   // Called by RenderView to tell us about painting events, these two functions
   // just correspond to the DidInitiatePaint and DidFlushPaint in R.V..
diff --git a/chrome/renderer/renderer_webcookiejar_impl.h b/chrome/renderer/renderer_webcookiejar_impl.h
index f8fee08..f004bed 100644
--- a/chrome/renderer/renderer_webcookiejar_impl.h
+++ b/chrome/renderer/renderer_webcookiejar_impl.h
@@ -20,6 +20,7 @@ class RendererWebCookieJarImpl : public WebKit::WebCookieJar {
   explicit RendererWebCookieJarImpl(IPC::Message::Sender* sender)
       : sender_(sender) {
   }
+  virtual ~RendererWebCookieJarImpl() {}
 
  private:
   // WebKit::WebCookieJar methods:
diff --git a/chrome/renderer/websharedworkerrepository_impl.h b/chrome/renderer/websharedworkerrepository_impl.h
index 7183171..745c094 100644
--- a/chrome/renderer/websharedworkerrepository_impl.h
+++ b/chrome/renderer/websharedworkerrepository_impl.h
@@ -16,12 +16,15 @@ namespace WebKit {
 
 class WebSharedWorkerRepositoryImpl : public WebKit::WebSharedWorkerRepository {
  public:
+    virtual ~WebSharedWorkerRepositoryImpl() {}
+
     virtual void addSharedWorker(WebKit::WebSharedWorker*, DocumentID document);
     virtual void documentDetached(DocumentID document);
 
     // Returns true if the document has created a SharedWorker (used by the
     // WebKit code to determine if the document can be suspended).
     virtual bool hasSharedWorkers(DocumentID document);
+
  private:
     // The set of documents that have created a SharedWorker.
     typedef base::hash_set<DocumentID> DocumentSet;