diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-08 00:47:23 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-08 00:47:23 +0000 |
| commit | b7c2f25802d9e74c4aec3f0b99feed1b7a951bad (patch) | |
| tree | e674c739e2fce2326f82e5b1997b0564e1e28a94 /chrome/renderer | |
| parent | 900eef6269a3fcf167bc1a05036b2b1420dd85e1 (diff) | |
| download | chromium_src-b7c2f25802d9e74c4aec3f0b99feed1b7a951bad.zip chromium_src-b7c2f25802d9e74c4aec3f0b99feed1b7a951bad.tar.gz chromium_src-b7c2f25802d9e74c4aec3f0b99feed1b7a951bad.tar.bz2 | |
Revert "Allow silent extension installations from the extensions gallery - Part 1."
Original CL: http://codereview.chromium.org/400018/show
Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this.
BUG=27431
TBR=aa
Review URL: http://codereview.chromium.org/467042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
| -rw-r--r-- | chrome/renderer/render_view.cc | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc index e368552..c47cd25 100644 --- a/chrome/renderer/render_view.cc +++ b/chrome/renderer/render_view.cc @@ -30,7 +30,6 @@ #include "chrome/common/child_process_logging.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_constants.h" -#include "chrome/common/extensions/extension.h" #include "chrome/common/jstemplate_builder.h" #include "chrome/common/page_zoom.h" #include "chrome/common/plugin_messages.h" @@ -1958,30 +1957,6 @@ WebNavigationPolicy RenderView::decidePolicyForNavigation( } } - // Extension gallery URLs are granted special permission to silently install - // extensions. If the navigation is either from or to a gallery URL, kick - // it up to browser so that the renderer process can be properly managed - // (i.e. display gallery urls in a seperate process that contains nothing - // else). - if (default_policy == WebKit::WebNavigationPolicyCurrentTab && - (is_content_initiated || is_redirect) && frame->parent() == NULL && - Extension::IsGalleryURL(url) != Extension::IsGalleryURL(frame->url())) { - // TODO(rafaelw): is it OK to use frame->url() as referrer rather than - // GURL() (as above)? - OpenURL(url, frame->url(), default_policy); - return WebKit::WebNavigationPolicyIgnore; // Suppress the load here. - } - - // The renderer for the extension gallery should not allow any non-gallery - // subframe navigations, since the frames would also have elevated - // permissions. - if (default_policy == WebKit::WebNavigationPolicyCurrentTab && - frame->parent() != NULL && - Extension::IsGalleryURL(frame->top()->url()) && - !Extension::IsGalleryURL(url)) { - return WebKit::WebNavigationPolicyIgnore; // Ignore the navigation. - } - // Detect when a page is "forking" a new tab that can be safely rendered in // its own process. This is done by sites like Gmail that try to open links // in new windows without script connections back to the original page. We |