summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 04:16:27 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 04:16:27 +0000
commitad8e04ac88be37d5ccb6c2cf61f52b224dca493c (patch)
tree9bcb878643bdd9e5af6749fff469b2552e569907 /chrome/renderer
parent5af8043eb24ad60251d8a4e33192e3e6f59246a3 (diff)
downloadchromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.zip
chromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.tar.gz
chromium_src-ad8e04ac88be37d5ccb6c2cf61f52b224dca493c.tar.bz2
Convert implicit scoped_refptr constructor calls to explicit ones, part 1
This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/renderer')
-rw-r--r--chrome/renderer/audio_message_filter_unittest.cc4
-rw-r--r--chrome/renderer/media/audio_renderer_impl_unittest.cc4
-rw-r--r--chrome/renderer/render_view.cc20
-rw-r--r--chrome/renderer/render_widget.cc4
-rw-r--r--chrome/renderer/render_widget_browsertest.cc2
-rw-r--r--chrome/renderer/render_widget_fullscreen.cc4
-rw-r--r--chrome/renderer/render_widget_fullscreen_pepper.cc4
-rw-r--r--chrome/renderer/renderer_webkitclient_impl.cc4
-rw-r--r--chrome/renderer/webplugin_delegate_pepper.cc8
-rw-r--r--chrome/renderer/webplugin_delegate_proxy.cc4
10 files changed, 29 insertions, 29 deletions
diff --git a/chrome/renderer/audio_message_filter_unittest.cc b/chrome/renderer/audio_message_filter_unittest.cc
index eae1f91..8c6b271 100644
--- a/chrome/renderer/audio_message_filter_unittest.cc
+++ b/chrome/renderer/audio_message_filter_unittest.cc
@@ -94,7 +94,7 @@ TEST(AudioMessageFilterTest, Basic) {
MessageLoop message_loop(MessageLoop::TYPE_IO);
const int kRouteId = 0;
- scoped_refptr<AudioMessageFilter> filter = new AudioMessageFilter(kRouteId);
+ scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter(kRouteId));
MockAudioDelegate delegate;
int stream_id = filter->AddDelegate(&delegate);
@@ -151,7 +151,7 @@ TEST(AudioMessageFilterTest, Delegates) {
MessageLoop message_loop(MessageLoop::TYPE_IO);
const int kRouteId = 0;
- scoped_refptr<AudioMessageFilter> filter = new AudioMessageFilter(kRouteId);
+ scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter(kRouteId));
MockAudioDelegate delegate1;
MockAudioDelegate delegate2;
diff --git a/chrome/renderer/media/audio_renderer_impl_unittest.cc b/chrome/renderer/media/audio_renderer_impl_unittest.cc
index 2c0ee96..6dd3dc7 100644
--- a/chrome/renderer/media/audio_renderer_impl_unittest.cc
+++ b/chrome/renderer/media/audio_renderer_impl_unittest.cc
@@ -127,7 +127,7 @@ TEST_F(AudioRendererImplTest, Stop) {
renderer_->OnVolume(0.5);
// It's possible that the upstream decoder replies right after being stopped.
- scoped_refptr<media::Buffer> buffer = new media::DataBuffer(kSize);
+ scoped_refptr<media::Buffer> buffer(new media::DataBuffer(kSize));
renderer_->ConsumeAudioSamples(buffer);
}
@@ -152,7 +152,7 @@ TEST_F(AudioRendererImplTest, DestroyedMessageLoop_SetVolume) {
TEST_F(AudioRendererImplTest, DestroyedMessageLoop_ConsumeAudioSamples) {
// Kill the message loop and verify OnReadComplete() still works.
message_loop_.reset();
- scoped_refptr<media::Buffer> buffer = new media::DataBuffer(kSize);
+ scoped_refptr<media::Buffer> buffer(new media::DataBuffer(kSize));
renderer_->ConsumeAudioSamples(buffer);
EXPECT_CALL(stop_callback_, OnFilterCallback());
renderer_->Stop(stop_callback_.NewCallback());
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index eed3618..d24b27b 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -594,8 +594,8 @@ RenderView* RenderView::Create(
int64 session_storage_namespace_id,
const string16& frame_name) {
DCHECK(routing_id != MSG_ROUTING_NONE);
- scoped_refptr<RenderView> view = new RenderView(render_thread, webkit_prefs,
- session_storage_namespace_id);
+ scoped_refptr<RenderView> view(new RenderView(render_thread, webkit_prefs,
+ session_storage_namespace_id));
view->Init(parent_hwnd,
opener_id,
renderer_prefs,
@@ -637,8 +637,8 @@ WebPlugin* RenderView::CreatePluginNoCheck(WebFrame* frame,
&info, &setting, &mime_type));
if (!found || !info.enabled)
return NULL;
- scoped_refptr<pepper::PluginModule> pepper_module =
- PepperPluginRegistry::GetInstance()->GetModule(info.path);
+ scoped_refptr<pepper::PluginModule> pepper_module(
+ PepperPluginRegistry::GetInstance()->GetModule(info.path));
if (pepper_module)
return CreatePepperPlugin(frame, params, info.path, pepper_module.get());
else
@@ -2538,8 +2538,8 @@ WebPlugin* RenderView::createPlugin(WebFrame* frame,
if (info.path.value() == kDefaultPluginLibraryName ||
setting == CONTENT_SETTING_ALLOW) {
- scoped_refptr<pepper::PluginModule> pepper_module =
- PepperPluginRegistry::GetInstance()->GetModule(info.path);
+ scoped_refptr<pepper::PluginModule> pepper_module(
+ PepperPluginRegistry::GetInstance()->GetModule(info.path));
if (pepper_module) {
return CreatePepperPlugin(frame,
params,
@@ -2658,14 +2658,14 @@ WebMediaPlayer* RenderView::createMediaPlayer(
scoped_refptr<webkit_glue::WebVideoRenderer> video_renderer;
if (cmd_line->HasSwitch(switches::kEnableVideoLayering)) {
- scoped_refptr<IPCVideoRenderer> renderer =
- new IPCVideoRenderer(routing_id_);
+ scoped_refptr<IPCVideoRenderer> renderer(
+ new IPCVideoRenderer(routing_id_));
collection.push_back(renderer);
video_renderer = renderer;
} else {
bool pts_logging = cmd_line->HasSwitch(switches::kEnableVideoLogging);
- scoped_refptr<webkit_glue::VideoRendererImpl> renderer =
- new webkit_glue::VideoRendererImpl(pts_logging);
+ scoped_refptr<webkit_glue::VideoRendererImpl> renderer(
+ new webkit_glue::VideoRendererImpl(pts_logging));
collection.push_back(renderer);
video_renderer = renderer;
}
diff --git a/chrome/renderer/render_widget.cc b/chrome/renderer/render_widget.cc
index 8880a03..17c0ee7 100644
--- a/chrome/renderer/render_widget.cc
+++ b/chrome/renderer/render_widget.cc
@@ -94,8 +94,8 @@ RenderWidget* RenderWidget::Create(int32 opener_id,
RenderThreadBase* render_thread,
WebKit::WebPopupType popup_type) {
DCHECK(opener_id != MSG_ROUTING_NONE);
- scoped_refptr<RenderWidget> widget = new RenderWidget(render_thread,
- popup_type);
+ scoped_refptr<RenderWidget> widget(new RenderWidget(render_thread,
+ popup_type));
widget->Init(opener_id); // adds reference
return widget;
}
diff --git a/chrome/renderer/render_widget_browsertest.cc b/chrome/renderer/render_widget_browsertest.cc
index ab7502c..ae955ad 100644
--- a/chrome/renderer/render_widget_browsertest.cc
+++ b/chrome/renderer/render_widget_browsertest.cc
@@ -128,7 +128,7 @@ bool RenderWidgetTest::ImageContainsColor(const SkBitmap& bitmap,
void RenderWidgetTest::OutputBitmapToFile(const SkBitmap& bitmap,
const FilePath& file_path) {
- scoped_refptr<RefCountedBytes> bitmap_data = new RefCountedBytes();
+ scoped_refptr<RefCountedBytes> bitmap_data(new RefCountedBytes());
SkAutoLockPixels lock(bitmap);
ASSERT_TRUE(gfx::JPEGCodec::Encode(
reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0)),
diff --git a/chrome/renderer/render_widget_fullscreen.cc b/chrome/renderer/render_widget_fullscreen.cc
index ce6f367..5a233f3 100644
--- a/chrome/renderer/render_widget_fullscreen.cc
+++ b/chrome/renderer/render_widget_fullscreen.cc
@@ -15,8 +15,8 @@ RenderWidgetFullscreen* RenderWidgetFullscreen::Create(
int32 opener_id, RenderThreadBase* render_thread,
WebKit::WebPopupType popup_type) {
DCHECK_NE(MSG_ROUTING_NONE, opener_id);
- scoped_refptr<RenderWidgetFullscreen> widget = new RenderWidgetFullscreen(
- render_thread, popup_type);
+ scoped_refptr<RenderWidgetFullscreen> widget(new RenderWidgetFullscreen(
+ render_thread, popup_type));
widget->Init(opener_id);
return widget.release();
}
diff --git a/chrome/renderer/render_widget_fullscreen_pepper.cc b/chrome/renderer/render_widget_fullscreen_pepper.cc
index 5b1b1f3..8ab647e 100644
--- a/chrome/renderer/render_widget_fullscreen_pepper.cc
+++ b/chrome/renderer/render_widget_fullscreen_pepper.cc
@@ -162,8 +162,8 @@ RenderWidgetFullscreenPepper* RenderWidgetFullscreenPepper::Create(
int32 opener_id, RenderThreadBase* render_thread,
pepper::PluginInstance* plugin) {
DCHECK_NE(MSG_ROUTING_NONE, opener_id);
- scoped_refptr<RenderWidgetFullscreenPepper> widget =
- new RenderWidgetFullscreenPepper(render_thread, plugin);
+ scoped_refptr<RenderWidgetFullscreenPepper> widget(
+ new RenderWidgetFullscreenPepper(render_thread, plugin));
widget->Init(opener_id);
return widget.release();
}
diff --git a/chrome/renderer/renderer_webkitclient_impl.cc b/chrome/renderer/renderer_webkitclient_impl.cc
index 2fb5efc..02ae535 100644
--- a/chrome/renderer/renderer_webkitclient_impl.cc
+++ b/chrome/renderer/renderer_webkitclient_impl.cc
@@ -181,8 +181,8 @@ bool RendererWebKitClientImpl::SendSyncMessageFromAnyThread(
if (render_thread)
return render_thread->Send(msg);
- scoped_refptr<IPC::SyncMessageFilter> sync_msg_filter =
- ChildThread::current()->sync_message_filter();
+ scoped_refptr<IPC::SyncMessageFilter> sync_msg_filter(
+ ChildThread::current()->sync_message_filter());
return sync_msg_filter->Send(msg);
}
diff --git a/chrome/renderer/webplugin_delegate_pepper.cc b/chrome/renderer/webplugin_delegate_pepper.cc
index 082fc82..0085234 100644
--- a/chrome/renderer/webplugin_delegate_pepper.cc
+++ b/chrome/renderer/webplugin_delegate_pepper.cc
@@ -114,8 +114,8 @@ WebPluginDelegatePepper* WebPluginDelegatePepper::Create(
const FilePath& filename,
const std::string& mime_type,
const base::WeakPtr<RenderView>& render_view) {
- scoped_refptr<NPAPI::PluginLib> plugin_lib =
- NPAPI::PluginLib::CreatePluginLib(filename);
+ scoped_refptr<NPAPI::PluginLib> plugin_lib(
+ NPAPI::PluginLib::CreatePluginLib(filename));
if (plugin_lib.get() == NULL)
return NULL;
@@ -123,8 +123,8 @@ WebPluginDelegatePepper* WebPluginDelegatePepper::Create(
if (err != NPERR_NO_ERROR)
return NULL;
- scoped_refptr<NPAPI::PluginInstance> instance =
- plugin_lib->CreateInstance(mime_type);
+ scoped_refptr<NPAPI::PluginInstance> instance(
+ plugin_lib->CreateInstance(mime_type));
return new WebPluginDelegatePepper(render_view,
instance.get());
}
diff --git a/chrome/renderer/webplugin_delegate_proxy.cc b/chrome/renderer/webplugin_delegate_proxy.cc
index d53909c..eff2d29 100644
--- a/chrome/renderer/webplugin_delegate_proxy.cc
+++ b/chrome/renderer/webplugin_delegate_proxy.cc
@@ -294,9 +294,9 @@ bool WebPluginDelegateProxy::Initialize(const GURL& url,
IPC::AddChannelSocket(channel_handle.name, channel_handle.socket.fd);
#endif
- scoped_refptr<PluginChannelHost> channel_host =
+ scoped_refptr<PluginChannelHost> channel_host(
PluginChannelHost::GetPluginChannelHost(
- channel_handle.name, ChildProcess::current()->io_message_loop());
+ channel_handle.name, ChildProcess::current()->io_message_loop()));
if (!channel_host.get())
return false;