diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-10 22:08:08 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-10 22:08:08 +0000 |
| commit | 23827ecacc856f01a55cd7102270c3ff86df042b (patch) | |
| tree | ac16dba390c6563f4085991a21ecdb07d4913086 /chrome/service/cloud_print | |
| parent | 77c6d060599dccd23ae1bb4ddbc809cb550d2178 (diff) | |
| download | chromium_src-23827ecacc856f01a55cd7102270c3ff86df042b.zip chromium_src-23827ecacc856f01a55cd7102270c3ff86df042b.tar.gz chromium_src-23827ecacc856f01a55cd7102270c3ff86df042b.tar.bz2 | |
Clean-up inline members of nested classes (chrome/)
Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.
The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.
BUG=139346
Review URL: https://chromiumcodereview.appspot.com/10855075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service/cloud_print')
| -rw-r--r-- | chrome/service/cloud_print/cloud_print_url_fetcher.cc | 29 | ||||
| -rw-r--r-- | chrome/service/cloud_print/cloud_print_url_fetcher.h | 16 |
2 files changed, 36 insertions, 9 deletions
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc index 95ed8db..77a37ce 100644 --- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc +++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc @@ -18,6 +18,35 @@ #include "net/url_request/url_fetcher.h" #include "net/url_request/url_request_status.h" + +CloudPrintURLFetcher::ResponseAction +CloudPrintURLFetcher::Delegate::HandleRawResponse( + const net::URLFetcher* source, + const GURL& url, + const net::URLRequestStatus& status, + int response_code, + const net::ResponseCookies& cookies, + const std::string& data) { + return CONTINUE_PROCESSING; +} + +CloudPrintURLFetcher::ResponseAction +CloudPrintURLFetcher::Delegate::HandleRawData( + const net::URLFetcher* source, + const GURL& url, + const std::string& data) { + return CONTINUE_PROCESSING; +} + +CloudPrintURLFetcher::ResponseAction +CloudPrintURLFetcher::Delegate::HandleJSONData( + const net::URLFetcher* source, + const GURL& url, + base::DictionaryValue* json_data, + bool succeeded) { + return CONTINUE_PROCESSING; +} + CloudPrintURLFetcher::CloudPrintURLFetcher() : delegate_(NULL), num_retries_(0) { diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h index 77bf8f68..d976f712 100644 --- a/chrome/service/cloud_print/cloud_print_url_fetcher.h +++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h @@ -50,9 +50,8 @@ class CloudPrintURLFetcher const net::URLRequestStatus& status, int response_code, const net::ResponseCookies& cookies, - const std::string& data) { - return CONTINUE_PROCESSING; - } + const std::string& data); + // This will be invoked only if HandleRawResponse returns // CONTINUE_PROCESSING AND if there are no network errors and the HTTP // response code is 200. The delegate implementation returns @@ -62,21 +61,20 @@ class CloudPrintURLFetcher // response). virtual ResponseAction HandleRawData(const net::URLFetcher* source, const GURL& url, - const std::string& data) { - return CONTINUE_PROCESSING; - } + const std::string& data); + // This will be invoked only if HandleRawResponse and HandleRawData return // CONTINUE_PROCESSING AND if the response contains a valid JSON dictionary. // |succeeded| is the value of the "success" field in the response JSON. virtual ResponseAction HandleJSONData(const net::URLFetcher* source, const GURL& url, base::DictionaryValue* json_data, - bool succeeded) { - return CONTINUE_PROCESSING; - } + bool succeeded); + // Invoked when the retry limit for this request has been reached (if there // was a retry limit - a limit of -1 implies no limit). virtual void OnRequestGiveUp() { } + // Invoked when the request returns a 403 error (applicable only when // HandleRawResponse returns CONTINUE_PROCESSING). // Returning RETRY_REQUEST will retry current request. (auth information |