diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
commit | cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622 (patch) | |
tree | 7b95f103fce509de887c8c5e643604855b57c0ba /chrome/service/service_process.cc | |
parent | 9f6e673c7f43f6ee414f72a74585dad8ebaceec3 (diff) | |
download | chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.zip chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.gz chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.bz2 |
Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service/service_process.cc')
-rw-r--r-- | chrome/service/service_process.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/service/service_process.cc b/chrome/service/service_process.cc index f59217e..af04fbd 100644 --- a/chrome/service/service_process.cc +++ b/chrome/service/service_process.cc @@ -163,7 +163,8 @@ bool ServiceProcess::Initialize(base::MessageLoopForUI* message_loop, user_data_dir.Append(chrome::kServiceStateFileName); service_prefs_.reset(new ServiceProcessPrefs( pref_path, - JsonPrefStore::GetTaskRunnerForFile(pref_path, blocking_pool_.get()))); + JsonPrefStore::GetTaskRunnerForFile(pref_path, blocking_pool_.get()) + .get())); service_prefs_->ReadPrefs(); // This switch it required to run connector with test gaia. @@ -203,8 +204,8 @@ bool ServiceProcess::Initialize(base::MessageLoopForUI* message_loop, // After the IPC server has started we signal that the service process is // ready. if (!service_process_state_->SignalReady( - io_thread_->message_loop_proxy(), - base::Bind(&ServiceProcess::Terminate, base::Unretained(this)))) { + io_thread_->message_loop_proxy().get(), + base::Bind(&ServiceProcess::Terminate, base::Unretained(this)))) { return false; } |