diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
| commit | 3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 (patch) | |
| tree | b26f7f81e48a95473eb4af5304301e9d8cd22fb8 /chrome/service | |
| parent | eef99b6591d82399096abdcee07dd67359eec036 (diff) | |
| download | chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.zip chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.gz chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.bz2 | |
Virtual destructors should have virtual keyword.
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
| -rw-r--r-- | chrome/service/cloud_print/printer_job_handler.h | 2 | ||||
| -rw-r--r-- | chrome/service/gaia/service_gaia_authenticator.h | 2 | ||||
| -rw-r--r-- | chrome/service/service_process.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/chrome/service/cloud_print/printer_job_handler.h b/chrome/service/cloud_print/printer_job_handler.h index 6e804f9..12e19df 100644 --- a/chrome/service/cloud_print/printer_job_handler.h +++ b/chrome/service/cloud_print/printer_job_handler.h @@ -113,7 +113,7 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>, const GURL& cloud_print_server_url, cloud_print::PrintSystem* print_system, Delegate* delegate); - ~PrinterJobHandler(); + virtual ~PrinterJobHandler(); bool Initialize(); // Requests a job check. |reason| is the reason for fetching the job. Used // for logging and diagnostc purposes. diff --git a/chrome/service/gaia/service_gaia_authenticator.h b/chrome/service/gaia/service_gaia_authenticator.h index 2010690..bb9424e 100644 --- a/chrome/service/gaia/service_gaia_authenticator.h +++ b/chrome/service/gaia/service_gaia_authenticator.h @@ -28,7 +28,7 @@ class ServiceGaiaAuthenticator const std::string& service_id, const std::string& gaia_url, base::MessageLoopProxy* io_message_loop_proxy); - ~ServiceGaiaAuthenticator(); + virtual ~ServiceGaiaAuthenticator(); // URLFetcher::Delegate implementation. virtual void OnURLFetchComplete(const URLFetcher *source, diff --git a/chrome/service/service_process.h b/chrome/service/service_process.h index 8d316b1..ce1fc5a 100644 --- a/chrome/service/service_process.h +++ b/chrome/service/service_process.h @@ -32,7 +32,7 @@ class CommandLine; class ServiceProcess : public CloudPrintProxy::Client { public: ServiceProcess(); - ~ServiceProcess(); + virtual ~ServiceProcess(); // Initialize the ServiceProcess with the message loop that it should run on. // ServiceProcess takes ownership of |state|. |