diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-19 16:57:03 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-19 16:57:03 +0000 |
commit | 8e38341c65360b48c32b88c58d6ac490516c0c0c (patch) | |
tree | 381bfdd42b59c1c4fa2368dec5ed479d83ab6f16 /chrome/service | |
parent | 0b97feeb41cb115158741daa975ec95d2e10cace (diff) | |
download | chromium_src-8e38341c65360b48c32b88c58d6ac490516c0c0c.zip chromium_src-8e38341c65360b48c32b88c58d6ac490516c0c0c.tar.gz chromium_src-8e38341c65360b48c32b88c58d6ac490516c0c0c.tar.bz2 |
FBTF: Even more ctor/virtual deinlining.
(Only 424k off Linux debug .a files).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
-rw-r--r-- | chrome/service/cloud_print/job_status_updater.cc | 2 | ||||
-rw-r--r-- | chrome/service/cloud_print/job_status_updater.h | 4 | ||||
-rw-r--r-- | chrome/service/net/service_url_request_context.cc | 24 | ||||
-rw-r--r-- | chrome/service/net/service_url_request_context.h | 17 |
4 files changed, 31 insertions, 16 deletions
diff --git a/chrome/service/cloud_print/job_status_updater.cc b/chrome/service/cloud_print/job_status_updater.cc index 7c7d1ca..1f36b2a 100644 --- a/chrome/service/cloud_print/job_status_updater.cc +++ b/chrome/service/cloud_print/job_status_updater.cc @@ -26,6 +26,8 @@ JobStatusUpdater::JobStatusUpdater(const std::string& printer_name, DCHECK(delegate_); } +JobStatusUpdater::~JobStatusUpdater() {} + // Start checking the status of the local print job. void JobStatusUpdater::UpdateStatus() { // It does not matter if we had already sent out an update and are waiting for diff --git a/chrome/service/cloud_print/job_status_updater.h b/chrome/service/cloud_print/job_status_updater.h index d617bde..6e111cd 100644 --- a/chrome/service/cloud_print/job_status_updater.h +++ b/chrome/service/cloud_print/job_status_updater.h @@ -39,10 +39,12 @@ class JobStatusUpdater : public base::RefCountedThreadSafe<JobStatusUpdater>, const GURL& cloud_print_server_url, cloud_print::PrintSystem* print_system, Delegate* delegate); - virtual ~JobStatusUpdater() {} + virtual ~JobStatusUpdater(); + // Checks the status of the local print job and sends an update. void UpdateStatus(); void Stop(); + // URLFetcher::Delegate implementation. virtual void OnURLFetchComplete(const URLFetcher* source, const GURL& url, const URLRequestStatus& status, diff --git a/chrome/service/net/service_url_request_context.cc b/chrome/service/net/service_url_request_context.cc index bd39292..3f264a4 100644 --- a/chrome/service/net/service_url_request_context.cc +++ b/chrome/service/net/service_url_request_context.cc @@ -4,6 +4,7 @@ #include "chrome/service/net/service_url_request_context.h" +#include "base/message_loop_proxy.h" #include "chrome/service/service_process.h" #include "net/base/cookie_monster.h" #include "net/base/cookie_policy.h" @@ -16,11 +17,6 @@ #include "net/http/http_network_layer.h" #include "net/proxy/proxy_service.h" -ServiceURLRequestContextGetter::ServiceURLRequestContextGetter() - : io_message_loop_proxy_( - g_service_process->io_thread()->message_loop_proxy()) { -} - ServiceURLRequestContext::ServiceURLRequestContext() { host_resolver_ = net::CreateSystemHostResolver(net::HostResolver::kDefaultParallelism, @@ -62,3 +58,21 @@ ServiceURLRequestContext::~ServiceURLRequestContext() { delete http_auth_handler_factory_; delete dnsrr_resolver_; } + +ServiceURLRequestContextGetter::ServiceURLRequestContextGetter() + : io_message_loop_proxy_( + g_service_process->io_thread()->message_loop_proxy()) { +} + +URLRequestContext* ServiceURLRequestContextGetter::GetURLRequestContext() { + if (!url_request_context_) + url_request_context_ = new ServiceURLRequestContext(); + return url_request_context_; +} + +scoped_refptr<base::MessageLoopProxy> +ServiceURLRequestContextGetter::GetIOMessageLoopProxy() { + return io_message_loop_proxy_; +} + +ServiceURLRequestContextGetter::~ServiceURLRequestContextGetter() {} diff --git a/chrome/service/net/service_url_request_context.h b/chrome/service/net/service_url_request_context.h index 33ab2e1..379371f 100644 --- a/chrome/service/net/service_url_request_context.h +++ b/chrome/service/net/service_url_request_context.h @@ -8,7 +8,6 @@ #include <string> -#include "base/message_loop_proxy.h" #include "chrome/common/net/url_request_context_getter.h" #include "net/base/cookie_monster.h" #include "net/base/cookie_policy.h" @@ -22,6 +21,10 @@ #include "net/proxy/proxy_service.h" #include "net/url_request/url_request_context.h" +namespace base { +class MessageLoopProxy; +} + // Subclass of URLRequestContext which can be used to store extra information // for requests. This subclass is meant to be used in the service process where // the profile is not available. @@ -55,20 +58,14 @@ class ServiceURLRequestContextGetter : public URLRequestContextGetter { public: ServiceURLRequestContextGetter(); - virtual URLRequestContext* GetURLRequestContext() { - if (!url_request_context_) - url_request_context_ = new ServiceURLRequestContext(); - return url_request_context_; - } - virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() { - return io_message_loop_proxy_; - } + virtual URLRequestContext* GetURLRequestContext(); + virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy(); void set_user_agent(const std::string& ua) { user_agent_ = ua; } private: - ~ServiceURLRequestContextGetter() {} + virtual ~ServiceURLRequestContextGetter(); std::string user_agent_; scoped_refptr<URLRequestContext> url_request_context_; |