diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-17 14:44:52 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-17 14:44:52 +0000 |
commit | dc04750a4da2b15e07c4cfc8b22ac53460e9f3cd (patch) | |
tree | 8399b1e1226b690d2c39de8dcf120e7dd6d9e88c /chrome/service | |
parent | 2c84baa742b7610eff54d26c83eaf45e724ecdbd (diff) | |
download | chromium_src-dc04750a4da2b15e07c4cfc8b22ac53460e9f3cd.zip chromium_src-dc04750a4da2b15e07c4cfc8b22ac53460e9f3cd.tar.gz chromium_src-dc04750a4da2b15e07c4cfc8b22ac53460e9f3cd.tar.bz2 |
Revert 223610 "Set the printer info in crash reports using the c..."
Reverting due to buffer overflow reported on the Linux mem bot.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/15489
> Set the printer info in crash reports using the crash key logging system.
>
> BUG=77656
> R=jochen@chromium.org
>
> Review URL: https://codereview.chromium.org/23604061
TBR=rsesek@chromium.org
Review URL: https://codereview.chromium.org/23503070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223613 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
-rw-r--r-- | chrome/service/cloud_print/print_system_cups.cc | 10 | ||||
-rw-r--r-- | chrome/service/cloud_print/print_system_win.cc | 14 |
2 files changed, 12 insertions, 12 deletions
diff --git a/chrome/service/cloud_print/print_system_cups.cc b/chrome/service/cloud_print/print_system_cups.cc index 18c4d4c..0d8f270 100644 --- a/chrome/service/cloud_print/print_system_cups.cc +++ b/chrome/service/cloud_print/print_system_cups.cc @@ -25,8 +25,8 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "base/values.h" +#include "chrome/common/child_process_logging.h" #include "chrome/common/cloud_print/cloud_print_constants.h" -#include "chrome/common/crash_keys.h" #include "chrome/service/cloud_print/cloud_print_helpers.h" #include "grit/generated_resources.h" #include "printing/backend/cups_helper.h" @@ -264,7 +264,7 @@ class PrinterWatcherCUPS PrintSystem::PrinterWatcher::Delegate* delegate) OVERRIDE{ scoped_refptr<printing::PrintBackend> print_backend( printing::PrintBackend::CreateInstance(NULL)); - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( print_backend->GetPrinterDriverInfo(printer_name_)); if (delegate_ != NULL) StopWatching(); @@ -595,7 +595,7 @@ bool PrintSystemCUPS::GetPrinterCapsAndDefaults( } // TODO(gene): Retry multiple times in case of error. - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( server_info->backend->GetPrinterDriverInfo(short_printer_name)); if (!server_info->backend->GetPrinterCapsAndDefaults(short_printer_name, printer_info) ) { @@ -618,7 +618,7 @@ bool PrintSystemCUPS::GetJobDetails(const std::string& printer_name, if (!server_info) return false; - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( server_info->backend->GetPrinterDriverInfo(short_printer_name)); cups_job_t* jobs = NULL; int num_jobs = GetJobs(&jobs, server_info->url, cups_encryption_, @@ -778,7 +778,7 @@ PlatformJobId PrintSystemCUPS::SpoolPrintJob( if (!server_info) return false; - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( server_info->backend->GetPrinterDriverInfo(printer_name)); // We need to store options as char* string for the duration of the diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc index 6d4fa9a..e70e398b 100644 --- a/chrome/service/cloud_print/print_system_win.cc +++ b/chrome/service/cloud_print/print_system_win.cc @@ -18,7 +18,7 @@ #include "base/win/scoped_com_initializer.h" #include "base/win/scoped_comptr.h" #include "base/win/scoped_hdc.h" -#include "chrome/common/crash_keys.h" +#include "chrome/common/child_process_logging.h" #include "chrome/service/service_process.h" #include "chrome/service/service_utility_process_host.h" #include "grit/generated_resources.h" @@ -170,7 +170,7 @@ class PrintSystemWatcherWin : public base::win::ObjectWatcher::Delegate { scoped_refptr<printing::PrintBackend> print_backend( printing::PrintBackend::CreateInstance(NULL)); printer_info_ = print_backend->GetPrinterDriverInfo(printer_name); - crash_keys::ScopedPrinterInfo crash_key(printer_info_); + child_process_logging::ScopedPrinterInfoSetter prn_info(printer_info_); delegate_ = delegate; // An empty printer name means watch the current server, we need to pass @@ -203,7 +203,7 @@ class PrintSystemWatcherWin : public base::win::ObjectWatcher::Delegate { // base::ObjectWatcher::Delegate method virtual void OnObjectSignaled(HANDLE object) { - crash_keys::ScopedPrinterInfo crash_key(printer_info_); + child_process_logging::ScopedPrinterInfoSetter prn_info(printer_info_); DWORD change = 0; FindNextPrinterChangeNotification(object, &change, NULL, NULL); @@ -370,7 +370,7 @@ class PrintSystemWin : public PrintSystem { // TODO(gene): add tags handling. scoped_refptr<printing::PrintBackend> print_backend( printing::PrintBackend::CreateInstance(NULL)); - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( print_backend->GetPrinterDriverInfo(printer_name)); return core_->Spool(print_ticket, print_data_file_path, print_data_mime_type, printer_name, job_title, @@ -403,7 +403,7 @@ class PrintSystemWin : public PrintSystem { JobSpooler::Delegate* delegate) { scoped_refptr<printing::PrintBackend> print_backend( printing::PrintBackend::CreateInstance(NULL)); - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( print_backend->GetPrinterDriverInfo(printer_name)); if (delegate_) { // We are already in the process of printing. @@ -792,7 +792,7 @@ bool PrintSystemWin::IsValidPrinter(const std::string& printer_name) { bool PrintSystemWin::ValidatePrintTicket( const std::string& printer_name, const std::string& print_ticket_data) { - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( print_backend_->GetPrinterDriverInfo(printer_name)); printing::ScopedXPSInitializer xps_initializer; if (!xps_initializer.initialized()) { @@ -833,7 +833,7 @@ bool PrintSystemWin::ValidatePrintTicket( bool PrintSystemWin::GetJobDetails(const std::string& printer_name, PlatformJobId job_id, PrintJobDetails *job_details) { - crash_keys::ScopedPrinterInfo crash_key( + child_process_logging::ScopedPrinterInfoSetter prn_info( print_backend_->GetPrinterDriverInfo(printer_name)); DCHECK(job_details); printing::ScopedPrinterHandle printer_handle; |