diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-26 20:23:44 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-26 20:23:44 +0000 |
| commit | d2db029ab5a3ee3d103d71447467f7f0074869dc (patch) | |
| tree | 38d2cc560189c0d79493460051764e5a3a5bbd4c /chrome/service | |
| parent | 48f1e5cb62b299a83d7ae5f897eca0a587abf3f0 (diff) | |
| download | chromium_src-d2db029ab5a3ee3d103d71447467f7f0074869dc.zip chromium_src-d2db029ab5a3ee3d103d71447467f7f0074869dc.tar.gz chromium_src-d2db029ab5a3ee3d103d71447467f7f0074869dc.tar.bz2 | |
Clean up net unit testing code.
(Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.)
- Move code included from blah_unittest.h (where blah_unittest.cc has actual
unittests) into their own files, often completely out-of-lining the
definitions.
- Remove anonymous namespaces from headers.
- Reorder method declarations.
- Make other unit test link against net_test_support instead of reaching in and
including .h files in their targets directly.
BUG=68682
TEST=compiles
First Review URL: http://codereview.chromium.org/6264013
Review URL: http://codereview.chromium.org/6248021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
| -rw-r--r-- | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc index 50ecaab..6d399b0 100644 --- a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc +++ b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc @@ -5,16 +5,16 @@ #include "base/command_line.h" #include "base/message_loop_proxy.h" #include "base/ref_counted.h" -#include "base/threading/thread.h" #include "base/synchronization/waitable_event.h" +#include "base/threading/thread.h" #include "chrome/common/net/url_request_context_getter.h" -#include "chrome/service/service_process.h" #include "chrome/service/cloud_print/cloud_print_url_fetcher.h" +#include "chrome/service/service_process.h" #include "googleurl/src/gurl.h" #include "net/test/test_server.h" #include "net/url_request/url_request_status.h" +#include "net/url_request/url_request_test_util.h" #include "net/url_request/url_request_throttler_manager.h" -#include "net/url_request/url_request_unittest.h" #include "testing/gtest/include/gtest/gtest.h" using base::Time; |