diff options
| author | gene@chromium.org <gene@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 20:24:45 +0000 |
|---|---|---|
| committer | gene@chromium.org <gene@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 20:24:45 +0000 |
| commit | 2481d1c0916fd44347686b1040f5cb182c5d6e91 (patch) | |
| tree | d098dbaebaa87ce9ba661fcb1933dec9c4b9b1d8 /chrome/service | |
| parent | ed51dfedc9f4a074bbcf76bb6d8161d1cd983e7e (diff) | |
| download | chromium_src-2481d1c0916fd44347686b1040f5cb182c5d6e91.zip chromium_src-2481d1c0916fd44347686b1040f5cb182c5d6e91.tar.gz chromium_src-2481d1c0916fd44347686b1040f5cb182c5d6e91.tar.bz2 | |
Stop processing in case of authentication errors.
If recovering from auth error takes some significant time, it will reduce the number of wrong-auth requests.
Review URL: http://codereview.chromium.org/9959111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131001 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
| -rw-r--r-- | chrome/service/cloud_print/printer_job_handler.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/service/cloud_print/printer_job_handler.cc b/chrome/service/cloud_print/printer_job_handler.cc index 60639ee..b084c06 100644 --- a/chrome/service/cloud_print/printer_job_handler.cc +++ b/chrome/service/cloud_print/printer_job_handler.cc @@ -308,10 +308,12 @@ void PrinterJobHandler::OnRequestGiveUp() { } CloudPrintURLFetcher::ResponseAction PrinterJobHandler::OnRequestAuthError() { - // TODO(gene): We might consider stop processing if we get auth error here. + // We got an Auth error and have no idea how long it will take to refresh + // auth information (may take forever). We'll drop current request and + // propagate this error to the upper level. After auth issues will be + // resolved, GCP connector will restart. OnAuthError(); - // Continue processing as a network error. - return CloudPrintURLFetcher::CONTINUE_PROCESSING; + return CloudPrintURLFetcher::STOP_PROCESSING; } std::string PrinterJobHandler::GetAuthHeader() { |