diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-19 01:42:21 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-19 01:42:21 +0000 |
commit | ca56190fe41f3f7d8839cb084e35295349a3d5b3 (patch) | |
tree | 415b4e1821f5b8b21767043b0f51f3a5f43d4d62 /chrome/service | |
parent | 78434748d9e82a4e4cf3d98cf6a2a1f8d6168829 (diff) | |
download | chromium_src-ca56190fe41f3f7d8839cb084e35295349a3d5b3.zip chromium_src-ca56190fe41f3f7d8839cb084e35295349a3d5b3.tar.gz chromium_src-ca56190fe41f3f7d8839cb084e35295349a3d5b3.tar.bz2 |
Add OVERRIDE to chrome/service/.
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8549032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110808 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/service')
-rw-r--r-- | chrome/service/cloud_print/cloud_print_auth.h | 14 | ||||
-rw-r--r-- | chrome/service/cloud_print/cloud_print_connector.h | 14 | ||||
-rw-r--r-- | chrome/service/cloud_print/cloud_print_proxy.h | 6 | ||||
-rw-r--r-- | chrome/service/cloud_print/cloud_print_url_fetcher.h | 2 | ||||
-rw-r--r-- | chrome/service/cloud_print/job_status_updater.h | 6 | ||||
-rw-r--r-- | chrome/service/cloud_print/printer_job_handler.h | 27 | ||||
-rw-r--r-- | chrome/service/gaia/service_gaia_authenticator.h | 8 | ||||
-rw-r--r-- | chrome/service/net/service_url_request_context.h | 7 | ||||
-rw-r--r-- | chrome/service/service_ipc_server.h | 2 | ||||
-rw-r--r-- | chrome/service/service_process.h | 4 | ||||
-rw-r--r-- | chrome/service/service_utility_process_host.h | 6 |
11 files changed, 50 insertions, 46 deletions
diff --git a/chrome/service/cloud_print/cloud_print_auth.h b/chrome/service/cloud_print/cloud_print_auth.h index 7eea7f4..4442bb7 100644 --- a/chrome/service/cloud_print/cloud_print_auth.h +++ b/chrome/service/cloud_print/cloud_print_auth.h @@ -67,20 +67,20 @@ class CloudPrintAuth // gaia::GaiaOAuthClient::Delegate implementation. virtual void OnGetTokensResponse(const std::string& refresh_token, const std::string& access_token, - int expires_in_seconds); + int expires_in_seconds) OVERRIDE; virtual void OnRefreshTokenResponse(const std::string& access_token, - int expires_in_seconds); - virtual void OnOAuthError(); - virtual void OnNetworkError(int response_code); + int expires_in_seconds) OVERRIDE; + virtual void OnOAuthError() OVERRIDE; + virtual void OnNetworkError(int response_code) OVERRIDE; // CloudPrintURLFetcher::Delegate implementation. virtual CloudPrintURLFetcher::ResponseAction HandleJSONData( const content::URLFetcher* source, const GURL& url, base::DictionaryValue* json_data, - bool succeeded); - virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError(); - virtual std::string GetAuthHeader(); + bool succeeded) OVERRIDE; + virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() OVERRIDE; + virtual std::string GetAuthHeader() OVERRIDE; private: Client* client_; diff --git a/chrome/service/cloud_print/cloud_print_connector.h b/chrome/service/cloud_print/cloud_print_connector.h index 02493fb..34cf828 100644 --- a/chrome/service/cloud_print/cloud_print_connector.h +++ b/chrome/service/cloud_print/cloud_print_connector.h @@ -53,24 +53,24 @@ class CloudPrintConnector void CheckForJobs(const std::string& reason, const std::string& printer_id); // cloud_print::PrintServerWatcherDelegate implementation - virtual void OnPrinterAdded(); + virtual void OnPrinterAdded() OVERRIDE; // PrinterJobHandler::Delegate implementation - virtual void OnPrinterDeleted(const std::string& printer_name); - virtual void OnAuthError(); + virtual void OnPrinterDeleted(const std::string& printer_name) OVERRIDE; + virtual void OnAuthError() OVERRIDE; // CloudPrintURLFetcher::Delegate implementation. virtual CloudPrintURLFetcher::ResponseAction HandleRawData( const content::URLFetcher* source, const GURL& url, - const std::string& data); + const std::string& data) OVERRIDE; virtual CloudPrintURLFetcher::ResponseAction HandleJSONData( const content::URLFetcher* source, const GURL& url, base::DictionaryValue* json_data, - bool succeeded); - virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError(); - virtual std::string GetAuthHeader(); + bool succeeded) OVERRIDE; + virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() OVERRIDE; + virtual std::string GetAuthHeader() OVERRIDE; private: // Prototype for a response handler. diff --git a/chrome/service/cloud_print/cloud_print_proxy.h b/chrome/service/cloud_print/cloud_print_proxy.h index 64c79f5..2cd834bb 100644 --- a/chrome/service/cloud_print/cloud_print_proxy.h +++ b/chrome/service/cloud_print/cloud_print_proxy.h @@ -54,9 +54,9 @@ class CloudPrintProxy : public CloudPrintProxyFrontend, // CloudPrintProxyFrontend implementation. Called on UI thread. virtual void OnAuthenticated(const std::string& robot_oauth_refresh_token, const std::string& robot_email, - const std::string& user_email); - virtual void OnAuthenticationFailed(); - virtual void OnPrintSystemUnavailable(); + const std::string& user_email) OVERRIDE; + virtual void OnAuthenticationFailed() OVERRIDE; + virtual void OnPrintSystemUnavailable() OVERRIDE; protected: void Shutdown(); diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h index 2d26bb8..398af47 100644 --- a/chrome/service/cloud_print/cloud_print_url_fetcher.h +++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h @@ -107,7 +107,7 @@ class CloudPrintURLFetcher const std::string& additional_headers); // content::URLFetcherDelegate implementation. - virtual void OnURLFetchComplete(const content::URLFetcher* source); + virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE; protected: friend class base::RefCountedThreadSafe<CloudPrintURLFetcher>; diff --git a/chrome/service/cloud_print/job_status_updater.h b/chrome/service/cloud_print/job_status_updater.h index aaacc2c..a6ad103 100644 --- a/chrome/service/cloud_print/job_status_updater.h +++ b/chrome/service/cloud_print/job_status_updater.h @@ -49,9 +49,9 @@ class JobStatusUpdater : public base::RefCountedThreadSafe<JobStatusUpdater>, const content::URLFetcher* source, const GURL& url, base::DictionaryValue* json_data, - bool succeeded); - virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError(); - virtual std::string GetAuthHeader(); + bool succeeded) OVERRIDE; + virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() OVERRIDE; + virtual std::string GetAuthHeader() OVERRIDE; private: std::string printer_name_; diff --git a/chrome/service/cloud_print/printer_job_handler.h b/chrome/service/cloud_print/printer_job_handler.h index 03b50f7..a9de178 100644 --- a/chrome/service/cloud_print/printer_job_handler.h +++ b/chrome/service/cloud_print/printer_job_handler.h @@ -129,33 +129,34 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>, const net::URLRequestStatus& status, int response_code, const net::ResponseCookies& cookies, - const std::string& data); + const std::string& data) OVERRIDE; virtual CloudPrintURLFetcher::ResponseAction HandleRawData( const content::URLFetcher* source, const GURL& url, - const std::string& data); + const std::string& data) OVERRIDE; virtual CloudPrintURLFetcher::ResponseAction HandleJSONData( const content::URLFetcher* source, const GURL& url, base::DictionaryValue* json_data, - bool succeeded); - virtual void OnRequestGiveUp(); - virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError(); - virtual std::string GetAuthHeader(); + bool succeeded) OVERRIDE; + virtual void OnRequestGiveUp() OVERRIDE; + virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() OVERRIDE; + virtual std::string GetAuthHeader() OVERRIDE; // JobStatusUpdater::Delegate implementation - virtual bool OnJobCompleted(JobStatusUpdater* updater); - virtual void OnAuthError(); + virtual bool OnJobCompleted(JobStatusUpdater* updater) OVERRIDE; + virtual void OnAuthError() OVERRIDE; // cloud_print::PrinterWatcherDelegate implementation - virtual void OnPrinterDeleted(); - virtual void OnPrinterChanged(); - virtual void OnJobChanged(); + virtual void OnPrinterDeleted() OVERRIDE; + virtual void OnPrinterChanged() OVERRIDE; + virtual void OnJobChanged() OVERRIDE; // cloud_print::JobSpoolerDelegate implementation. // Called on print_thread_. - virtual void OnJobSpoolSucceeded(const cloud_print::PlatformJobId& job_id); - virtual void OnJobSpoolFailed(); + virtual void OnJobSpoolSucceeded( + const cloud_print::PlatformJobId& job_id) OVERRIDE; + virtual void OnJobSpoolFailed() OVERRIDE; // End Delegate implementations diff --git a/chrome/service/gaia/service_gaia_authenticator.h b/chrome/service/gaia/service_gaia_authenticator.h index 11e22a3..142e322 100644 --- a/chrome/service/gaia/service_gaia_authenticator.h +++ b/chrome/service/gaia/service_gaia_authenticator.h @@ -36,9 +36,11 @@ class ServiceGaiaAuthenticator protected: // GaiaAuthenticator overrides. - virtual bool Post(const GURL& url, const std::string& post_body, - unsigned long* response_code, std::string* response_body); - virtual int GetBackoffDelaySeconds(int current_backoff_delay); + virtual bool Post(const GURL& url, + const std::string& post_body, + unsigned long* response_code, + std::string* response_body) OVERRIDE; + virtual int GetBackoffDelaySeconds(int current_backoff_delay) OVERRIDE; private: void DoPost(const GURL& post_url, const std::string& post_body); diff --git a/chrome/service/net/service_url_request_context.h b/chrome/service/net/service_url_request_context.h index 1b13f5a..92ca26d 100644 --- a/chrome/service/net/service_url_request_context.h +++ b/chrome/service/net/service_url_request_context.h @@ -41,7 +41,7 @@ class ServiceURLRequestContext : public net::URLRequestContext { net::ProxyConfigService* net_proxy_config_service); // Overridden from net::URLRequestContext: - virtual const std::string& GetUserAgent(const GURL& url) const; + virtual const std::string& GetUserAgent(const GURL& url) const OVERRIDE; protected: virtual ~ServiceURLRequestContext(); @@ -53,8 +53,9 @@ class ServiceURLRequestContext : public net::URLRequestContext { class ServiceURLRequestContextGetter : public net::URLRequestContextGetter { public: - virtual net::URLRequestContext* GetURLRequestContext(); - virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const; + virtual net::URLRequestContext* GetURLRequestContext() OVERRIDE; + virtual scoped_refptr<base::MessageLoopProxy> + GetIOMessageLoopProxy() const OVERRIDE; void set_user_agent(const std::string& ua) { user_agent_ = ua; diff --git a/chrome/service/service_ipc_server.h b/chrome/service/service_ipc_server.h index 513f77e..e309f94 100644 --- a/chrome/service/service_ipc_server.h +++ b/chrome/service/service_ipc_server.h @@ -23,7 +23,7 @@ class ServiceIPCServer : public IPC::Channel::Listener, bool Init(); // IPC::Message::Sender implementation. - virtual bool Send(IPC::Message* msg); + virtual bool Send(IPC::Message* msg) OVERRIDE; IPC::SyncChannel* channel() { return channel_.get(); } diff --git a/chrome/service/service_process.h b/chrome/service/service_process.h index 55f265e..4468bca 100644 --- a/chrome/service/service_process.h +++ b/chrome/service/service_process.h @@ -93,8 +93,8 @@ class ServiceProcess : public CloudPrintProxy::Client { CloudPrintProxy* GetCloudPrintProxy(); // CloudPrintProxy::Client implementation. - virtual void OnCloudPrintProxyEnabled(bool persist_state); - virtual void OnCloudPrintProxyDisabled(bool persist_state); + virtual void OnCloudPrintProxyEnabled(bool persist_state) OVERRIDE; + virtual void OnCloudPrintProxyDisabled(bool persist_state) OVERRIDE; ServiceURLRequestContextGetter* GetServiceURLRequestContextGetter(); diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h index 9811ed9..8e49a3d 100644 --- a/chrome/service/service_utility_process_host.h +++ b/chrome/service/service_utility_process_host.h @@ -106,8 +106,8 @@ class ServiceUtilityProcessHost : public ServiceChildProcessHost { virtual FilePath GetUtilityProcessCmd(); // Overriden from ChildProcessHost. - virtual bool CanShutdown(); - virtual void OnChildDied(); + virtual bool CanShutdown() OVERRIDE; + virtual void OnChildDied() OVERRIDE; private: // Starts a process. Returns true iff it succeeded. |exposed_dir| is the @@ -116,7 +116,7 @@ class ServiceUtilityProcessHost : public ServiceChildProcessHost { bool StartProcess(bool no_sandbox, const FilePath& exposed_dir); // IPC messages: - virtual bool OnMessageReceived(const IPC::Message& message); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Called when at least one page in the specified PDF has been rendered // successfully into metafile_path_; void OnRenderPDFPagesToMetafileSucceeded(int highest_rendered_page_number); |